Re: [ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-07-16 Thread William Tu
> > > > Hi > > > > Thanks for your review. I test it with openflow, It works fine because > > > > the *revalidator > > > > will clean up the flows(which may be offloaded). > > > > > In case above scenario leaves ufids in OVS that cannot be removed, > > > > > I'd suggest > > > > > reverting of the

Re: [ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-07-15 Thread Tonghao Zhang
On Thu, Jun 18, 2020 at 7:41 PM Tonghao Zhang wrote: > > On Thu, Jun 18, 2020 at 7:18 PM Simon Horman > wrote: > > > > On Tue, Jun 16, 2020 at 04:25:21PM +0800, Tonghao Zhang wrote: > > > On Mon, Jun 15, 2020 at 7:13 PM Ilya Maximets wrote: > > > > > > > > On 6/14/20 1:40 PM, Tonghao Zhang wrot

Re: [ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-06-18 Thread Tonghao Zhang
On Thu, Jun 18, 2020 at 7:18 PM Simon Horman wrote: > > On Tue, Jun 16, 2020 at 04:25:21PM +0800, Tonghao Zhang wrote: > > On Mon, Jun 15, 2020 at 7:13 PM Ilya Maximets wrote: > > > > > > On 6/14/20 1:40 PM, Tonghao Zhang wrote: > > > > On Sun, Jun 14, 2020 at 1:31 PM Roi Dayan wrote: > > > >> >

Re: [ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-06-18 Thread Simon Horman
On Tue, Jun 16, 2020 at 04:25:21PM +0800, Tonghao Zhang wrote: > On Mon, Jun 15, 2020 at 7:13 PM Ilya Maximets wrote: > > > > On 6/14/20 1:40 PM, Tonghao Zhang wrote: > > > On Sun, Jun 14, 2020 at 1:31 PM Roi Dayan wrote: > > >> > > >> > > >> > > >> On 2020-06-11 1:36 PM, xiangxia.m@gmail.com

Re: [ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-06-16 Thread Tonghao Zhang
On Mon, Jun 15, 2020 at 7:13 PM Ilya Maximets wrote: > > On 6/14/20 1:40 PM, Tonghao Zhang wrote: > > On Sun, Jun 14, 2020 at 1:31 PM Roi Dayan wrote: > >> > >> > >> > >> On 2020-06-11 1:36 PM, xiangxia.m@gmail.com wrote: > >>> From: Tonghao Zhang > >>> > >>> When ports were removed from bri

Re: [ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-06-15 Thread Ilya Maximets
On 6/14/20 1:40 PM, Tonghao Zhang wrote: > On Sun, Jun 14, 2020 at 1:31 PM Roi Dayan wrote: >> >> >> >> On 2020-06-11 1:36 PM, xiangxia.m@gmail.com wrote: >>> From: Tonghao Zhang >>> >>> When ports were removed from bridge, we should flush the >>> offload rules on the ports. The main reason i

Re: [ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-06-14 Thread Tonghao Zhang
On Sun, Jun 14, 2020 at 1:31 PM Roi Dayan wrote: > > > > On 2020-06-11 1:36 PM, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > When ports were removed from bridge, we should flush the > > offload rules on the ports. The main reason is two factors: > > > > * The ports removed from

Re: [ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-06-13 Thread Roi Dayan
On 2020-06-11 1:36 PM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > When ports were removed from bridge, we should flush the > offload rules on the ports. The main reason is two factors: > > * The ports removed from bridge, will be managed by OvS, so > flush the rules which ins

Re: [ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-06-11 Thread 0-day Robot
Bleep bloop. Greetings Tonghao Zhang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Co-author Wengang Hou needs to sign off. Lines checked: 48, Warnings: 0, Errors: 1 P

[ovs-dev] [PATCH ovs-dev v1] netdev-offload: Flush offloaded rules when ports removed

2020-06-11 Thread xiangxia . m . yue
From: Tonghao Zhang When ports were removed from bridge, we should flush the offload rules on the ports. The main reason is two factors: * The ports removed from bridge, will be managed by OvS, so flush the rules which installed by OvS. * If using the TC flower offload, for example, tc rules s