[ovs-dev] [PATCH ovs resend v2] dpctl-netdev: Add the option "pmd" for dump-flows

2020-08-23 Thread xiangxia . m . yue
From: Tonghao Zhang "ovs-appctl dpctl/dump-flows" added the option "pmd" which allow user to dump pmd specified. That option is useful to dump rules of pmd when we have a large number of rules in dp. Signed-off-by: Tonghao Zhang --- NEWS| 2 ++ lib/dpctl.c | 28 ++

Re: [ovs-dev] [PATCH ovs resend v2] dpctl-netdev: Add the option "pmd" for dump-flows

2020-08-23 Thread 0-day Robot
Bleep bloop. Greetings Tonghao Zhang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 175 characters long (recommended limit is 79) #113 FILE: lib/dpctl.man:107: .

Re: [ovs-dev] [PATCH ovs resend v2] dpctl-netdev: Add the option "pmd" for dump-flows

2020-09-03 Thread Flavio Leitner
Hi, Thanks for the patch. I just did a quick look and found couple things to discuss. On Mon, Aug 24, 2020 at 10:44:08AM +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > "ovs-appctl dpctl/dump-flows" added the option > "pmd" which allow user to dump pmd specified. > > That op

Re: [ovs-dev] [PATCH ovs resend v2] dpctl-netdev: Add the option "pmd" for dump-flows

2020-09-03 Thread Ilya Maximets
On 8/24/20 4:44 AM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > "ovs-appctl dpctl/dump-flows" added the option > "pmd" which allow user to dump pmd specified. > > That option is useful to dump rules of pmd > when we have a large number of rules in dp. Is this a performance concern

Re: [ovs-dev] [PATCH ovs resend v2] dpctl-netdev: Add the option "pmd" for dump-flows

2020-09-06 Thread Tonghao Zhang
On Thu, Sep 3, 2020 at 8:31 PM Flavio Leitner wrote: > > > Hi, > > Thanks for the patch. I just did a quick look and found couple > things to discuss. > > On Mon, Aug 24, 2020 at 10:44:08AM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > "ovs-appctl dpctl/dump-flows" added

Re: [ovs-dev] [PATCH ovs resend v2] dpctl-netdev: Add the option "pmd" for dump-flows

2020-09-06 Thread Tonghao Zhang
On Thu, Sep 3, 2020 at 8:51 PM Ilya Maximets wrote: > > On 8/24/20 4:44 AM, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > "ovs-appctl dpctl/dump-flows" added the option > > "pmd" which allow user to dump pmd specified. > > > > That option is useful to dump rules of pmd > > when

Re: [ovs-dev] [PATCH ovs resend v2] dpctl-netdev: Add the option "pmd" for dump-flows

2020-09-07 Thread Ilya Maximets
On 9/7/20 7:29 AM, Tonghao Zhang wrote: > On Thu, Sep 3, 2020 at 8:51 PM Ilya Maximets wrote: >> >> On 8/24/20 4:44 AM, xiangxia.m@gmail.com wrote: >>> From: Tonghao Zhang >>> >>> "ovs-appctl dpctl/dump-flows" added the option >>> "pmd" which allow user to dump pmd specified. >>> >>> That opt

Re: [ovs-dev] [PATCH ovs resend v2] dpctl-netdev: Add the option "pmd" for dump-flows

2020-09-07 Thread Tonghao Zhang
On Mon, Sep 7, 2020 at 9:01 PM Ilya Maximets wrote: > > On 9/7/20 7:29 AM, Tonghao Zhang wrote: > > On Thu, Sep 3, 2020 at 8:51 PM Ilya Maximets wrote: > >> > >> On 8/24/20 4:44 AM, xiangxia.m@gmail.com wrote: > >>> From: Tonghao Zhang > >>> > >>> "ovs-appctl dpctl/dump-flows" added the opti