Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-02-27 Thread Anju Thomas
eaks . We can widely review the > >> other part of the code as it might require more indepth testing and review. > >> > >> What are your suggestions ? > >> > >> Regards > >> Anju > >> > >> -Original Message- > >> F

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-02-26 Thread Ben Pfaff
of the code as it might require more indepth testing and review. > >> > >> What are your suggestions ? > >> > >> Regards > >> Anju > >> > >> -Original Message- > >> From: Ben Pfaff [mailto:blp at ovn.org] > >&

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-02-26 Thread Ilya Maximets
>> From: Ben Pfaff [mailto:blp at ovn.org] >> Sent: Thursday, January 17, 2019 11:39 PM >> To: Stokes, Ian >> Cc: Lam, Tiago ; Anju Thomas > ericsson.com>; dev at openvswitch.org >> Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tn

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-22 Thread Anju Thomas
Thanks Ben. Regards Anju -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Wednesday, January 23, 2019 5:24 AM To: Anju Thomas Cc: Stokes, Ian ; Lam, Tiago ; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action OK. I applied

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-22 Thread Ben Pfaff
-Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, January 17, 2019 11:39 PM > To: Stokes, Ian > Cc: Lam, Tiago ; Anju Thomas ; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action > &

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-20 Thread Anju Thomas
Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action On Wed, Jan 16, 2019 at 11:38:38AM +, Stokes, Ian wrote: > > On 16/01/2019 09:30, Anju Thomas wrote: > > > > > > Hi Folks, > > > > > > Are these changes planned to be merged as well?

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-17 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 11:38:38AM +, Stokes, Ian wrote: > > On 16/01/2019 09:30, Anju Thomas wrote: > > > > > > Hi Folks, > > > > > > Are these changes planned to be merged as well? > > > > > > Regards > > > Anju > > > > Hi Anju, > > > > Unfortunately, no. An RFC based on the below was

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-16 Thread Anju Thomas
] [PATCH v1] Fix crash due to multiple tnl push action > On 16/01/2019 09:30, Anju Thomas wrote: > > > > Hi Folks, > > > > Are these changes planned to be merged as well? > > > > Regards > > Anju > > Hi Anju, > > Unfortunately, no. An RFC based

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-16 Thread Stokes, Ian
> On 16/01/2019 09:30, Anju Thomas wrote: > > > > Hi Folks, > > > > Are these changes planned to be merged as well? > > > > Regards > > Anju > > Hi Anju, > > Unfortunately, no. An RFC based on the below was proposed to the mailing > list here [1], but no discussion / comments happened after

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-16 Thread Lam, Tiago
: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action > > On 25/06/2018 13:15, Anju Thomas wrote: >> Hi Ben, >> >> We are facing multiple such crashes on different computes in our >> deployments. Seems to be a pretty commo

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-16 Thread Anju Thomas
Hi Folks, Are these changes planned to be merged as well? Regards Anju -Original Message- From: Lam, Tiago [mailto:tiago@intel.com] Sent: Monday, July 02, 2018 11:27 PM To: Anju Thomas ; Ben Pfaff Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Fix crash due

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-07-02 Thread Lam, Tiago
On 25/06/2018 13:15, Anju Thomas wrote: > Hi Ben, > > We are facing multiple such crashes on different computes in our deployments. > Seems to be a pretty common problem in our setup. As you suggested, it would > be good if we can make the below changes as well.How do you suggest we >

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-06-25 Thread Anju Thomas
& thanks Anju -Original Message- From: Anju Thomas Sent: Tuesday, June 05, 2018 10:26 AM To: Ben Pfaff Cc: d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action Hi , Any suggestions ? Will it be ok if we merge the tunnel push change that we

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-06-04 Thread Anju Thomas
c: d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action Hi Ben, I was working on the code changes and I can think of two approaches we can take to prevent this crash in the dpdk datapath. 1. Today the dp_packet module that we have is never return any error . The

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-17 Thread Anju Thomas
CH v1] Fix crash due to multiple tnl push action On Thu, May 10, 2018 at 08:51:03AM +, Anju Thomas wrote: > It looks like your commit message describes at least two other bugs in > OVS, though. First, if OVS crashes when it pushes tunnel headers, > even if there's not enough headroom

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-15 Thread Ilya Maximets
; Anju > > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, May 14, 2018 6:28 PM > To: ovs-dev@openvswitch.org; Anju Thomas <anju.tho...@ericsson.com>; Ben > Pfaff <b...@ovn.org> > Cc: Tiago Lam <tiago@intel.com

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-15 Thread Anju Thomas
.org; Anju Thomas <anju.tho...@ericsson.com>; Ben Pfaff <b...@ovn.org> Cc: Tiago Lam <tiago@intel.com> Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action Hello Anju, Ben, Looks like I fixed a leak reported here in my recent patch: https://mail.openvsw

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-14 Thread Ilya Maximets
Regards > Anju > > -Original Message- > From: Ben Pfaff [mailto:blp at ovn.org] > Sent: Friday, May 11, 2018 2:00 AM > To: Anju Thomas > Cc: dev at openvswitch.org > Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action > > On Thu, May 10

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-14 Thread Lam, Tiago
Hi Anju, On 10/05/2018 09:51, Anju Thomas wrote: [snip] > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, May 10, 2018 1:59 AM > To: Anju Thomas <anju.tho...@ericsson.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev]

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-14 Thread Anju Thomas
Hi Ben, I will work on these changes as well. Regards Anju -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Friday, May 11, 2018 2:00 AM To: Anju Thomas <anju.tho...@ericsson.com> Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multip

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-10 Thread Ben Pfaff
On Thu, May 10, 2018 at 08:51:03AM +, Anju Thomas wrote: > It looks like your commit message describes at least two other bugs in > OVS, though. First, if OVS crashes when it pushes tunnel headers, > even if there's not enough headroom, that's really bad. At worst, it > should drop the

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-10 Thread Anju Thomas
Hi Ben, Replies inline: Regards & thanks Anju -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Thursday, May 10, 2018 1:59 AM To: Anju Thomas <anju.tho...@ericsson.com> Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl p

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-09 Thread Ben Pfaff
On Tue, May 08, 2018 at 12:34:54AM +0530, Anju Thomas wrote: > During slow path packet processing, if the action is to output to a > tunnel port, the slow path processing of the encapsulated packet > continues on the underlay bridge and additional actions (e.g. optional > VLAN encapsulation, bond

[ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-05-07 Thread Anju Thomas
During slow path packet processing, if the action is to output to a tunnel port, the slow path processing of the encapsulated packet continues on the underlay bridge and additional actions (e.g. optional VLAN encapsulation, bond link selection and finally output to port) are collected there. To