Re: [ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-18 Thread Mike Pattrick
On Tue, Jan 18, 2022 at 2:24 PM Flavio Leitner wrote: > > On Tue, Jan 18, 2022 at 12:27:21PM -0500, Mike Pattrick wrote: > > On Tue, Jan 18, 2022 at 11:53 AM Flavio Leitner wrote: > > > > > > On Mon, Jan 17, 2022 at 09:47:18AM -0500, Mike Pattrick wrote: > > > > On Fri, Jan 14, 2022 at 4:13 PM

Re: [ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-18 Thread Flavio Leitner
On Tue, Jan 18, 2022 at 12:27:21PM -0500, Mike Pattrick wrote: > On Tue, Jan 18, 2022 at 11:53 AM Flavio Leitner wrote: > > > > On Mon, Jan 17, 2022 at 09:47:18AM -0500, Mike Pattrick wrote: > > > On Fri, Jan 14, 2022 at 4:13 PM Flavio Leitner wrote: > > > > > > > > On Fri, Jan 14, 2022 at

Re: [ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-18 Thread Mike Pattrick
On Tue, Jan 18, 2022 at 11:53 AM Flavio Leitner wrote: > > On Mon, Jan 17, 2022 at 09:47:18AM -0500, Mike Pattrick wrote: > > On Fri, Jan 14, 2022 at 4:13 PM Flavio Leitner wrote: > > > > > > On Fri, Jan 14, 2022 at 03:50:52PM -0500, Mike Pattrick wrote: > > > > On Fri, Jan 14, 2022 at 3:33 PM

Re: [ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-18 Thread Flavio Leitner
On Mon, Jan 17, 2022 at 09:47:18AM -0500, Mike Pattrick wrote: > On Fri, Jan 14, 2022 at 4:13 PM Flavio Leitner wrote: > > > > On Fri, Jan 14, 2022 at 03:50:52PM -0500, Mike Pattrick wrote: > > > On Fri, Jan 14, 2022 at 3:33 PM Flavio Leitner wrote: > > > > > > > > > > > > Hi Mike, > > > > > > >

Re: [ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-17 Thread Mike Pattrick
On Fri, Jan 14, 2022 at 4:13 PM Flavio Leitner wrote: > > On Fri, Jan 14, 2022 at 03:50:52PM -0500, Mike Pattrick wrote: > > On Fri, Jan 14, 2022 at 3:33 PM Flavio Leitner wrote: > > > > > > > > > Hi Mike, > > > > > > Thanks for working on this issue. > > > > > > On Fri, Jan 14, 2022 at

Re: [ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-14 Thread Flavio Leitner
On Fri, Jan 14, 2022 at 03:50:52PM -0500, Mike Pattrick wrote: > On Fri, Jan 14, 2022 at 3:33 PM Flavio Leitner wrote: > > > > > > Hi Mike, > > > > Thanks for working on this issue. > > > > On Fri, Jan 14, 2022 at 10:45:35AM -0500, Mike Pattrick wrote: > > > Formerly when userspace TSO was

Re: [ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-14 Thread Mike Pattrick
On Fri, Jan 14, 2022 at 3:33 PM Flavio Leitner wrote: > > > Hi Mike, > > Thanks for working on this issue. > > On Fri, Jan 14, 2022 at 10:45:35AM -0500, Mike Pattrick wrote: > > Formerly when userspace TSO was enabled but with a non-DKDK interface > > without support IP checksum offloading, FTP

Re: [ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-14 Thread Flavio Leitner
Hi Mike, Thanks for working on this issue. On Fri, Jan 14, 2022 at 10:45:35AM -0500, Mike Pattrick wrote: > Formerly when userspace TSO was enabled but with a non-DKDK interface > without support IP checksum offloading, FTP NAT connections would fail > if the packet length changed. This can

Re: [ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-14 Thread Aaron Conole
Mike Pattrick writes: > Formerly when userspace TSO was enabled but with a non-DKDK interface > without support IP checksum offloading, FTP NAT connections would fail > if the packet length changed. This can happen if the packets length > changes during L7 NAT translation, predominantly with

[ovs-dev] [PATCH v1] conntrack: Fix FTP NAT when TCP but not IP offload is supported

2022-01-14 Thread Mike Pattrick
Formerly when userspace TSO was enabled but with a non-DKDK interface without support IP checksum offloading, FTP NAT connections would fail if the packet length changed. This can happen if the packets length changes during L7 NAT translation, predominantly with FTP. Now we correct the IP header