Re: [ovs-dev] [PATCH v1] dpif-netdev: Update meter timestamp when dp_netdev_run_meter been called.

2023-06-22 Thread miter
Hi Ilya, Thanks for reviewing our code. We have 20+ threads indeed, so taking the same meter lock makes 'now' not updated timely. Using lockless meter to police traffic will be a perfect solution. :) Thanks a lot. On 6/22/2023 6:35 AM, Ilya Maximets wrote: On 6/21/23 18:07, Ilya Maximets

Re: [ovs-dev] [PATCH v1] dpif-netdev: Update meter timestamp when dp_netdev_run_meter been called.

2023-06-21 Thread Ilya Maximets
On 6/21/23 18:07, Ilya Maximets wrote: > On 5/31/23 17:41, mit...@outlook.com wrote: >> From: Lin Huang >> >> Currently, a meter's timestamp 'now' is set by 'pmd->ctx.now' which updated >> by pmd_thread_ctx_time_update(). >> >> Before processing of the new packet batch: >> - dpif_netdev_execute()

Re: [ovs-dev] [PATCH v1] dpif-netdev: Update meter timestamp when dp_netdev_run_meter been called.

2023-06-21 Thread Ilya Maximets
On 5/31/23 17:41, mit...@outlook.com wrote: > From: Lin Huang > > Currently, a meter's timestamp 'now' is set by 'pmd->ctx.now' which updated > by pmd_thread_ctx_time_update(). > > Before processing of the new packet batch: > - dpif_netdev_execute() > - dp_netdev_process_rxq_port() > > There

Re: [ovs-dev] [PATCH v1] dpif-netdev: Update meter timestamp when dp_netdev_run_meter been called.

2023-06-15 Thread miter
Hi/ilya,/ Could you please review my code? On 5/31/2023 11:41 PM, mit...@outlook.com wrote: From: Lin Huang Currently, a meter's timestamp 'now' is set by 'pmd->ctx.now' which updated by pmd_thread_ctx_time_update(). Before processing of the new packet batch: - dpif_netdev_execute() -

[ovs-dev] [PATCH v1] dpif-netdev: Update meter timestamp when dp_netdev_run_meter been called.

2023-05-31 Thread miterv
From: Lin Huang Currently, a meter's timestamp 'now' is set by 'pmd->ctx.now' which updated by pmd_thread_ctx_time_update(). Before processing of the new packet batch: - dpif_netdev_execute() - dp_netdev_process_rxq_port() There is a problem when user want to police the rate to a low pps by