Re: [ovs-dev] [PATCH v1] netdev-dpdk: Enable HW_CRC_STRIP for virtual functions.

2018-05-31 Thread Ferriter, Cian
ctl add-flow br0 > > > idle_timeout=0,in_port=2,action=output:1 > > > > > > The two findings from my testing: > > > * There are error messages coming from DPDK about promiscuous mode > > > on the port. Is this something that should be disabled or otherwise > > &

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Enable HW_CRC_STRIP for virtual functions.

2018-05-30 Thread Stokes, Ian
patch? > > * The patch doesn't apply cleanly to master. It looks like this is > > caused by the following patch: > > cferrite@silpixa00393943:~/ovs$ git show 65a87968f4 commit > > 65a87968f4cfd9cf7a433a3156d98118078f9e4e > > Author: Pablo Cascón > > Date: Fri Ap

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Enable HW_CRC_STRIP for virtual functions.

2018-05-30 Thread Stokes, Ian
49 2018 +0100 > > netdev-dpdk: don't enable scatter for jumbo RX support for nfp > > I have one comment about the code below, if this is addressed/resolved I'm > happy to give: > > Acked-by: Cian Ferriter > Tested-by: Cian Ferriter > > Thanks, > Cian &

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Enable HW_CRC_STRIP for virtual functions.

2018-05-25 Thread Ferriter, Cian
May 2018 14:25 > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v1] netdev-dpdk: Enable HW_CRC_STRIP for > virtual functions. > > From: Michal Weglicki > > Virtual functions such as igb_vf and i40e_vf require HW_CRC_STRIP to be > explicitly enabled before configurati

[ovs-dev] [PATCH v1] netdev-dpdk: Enable HW_CRC_STRIP for virtual functions.

2018-05-03 Thread Ian Stokes
From: Michal Weglicki Virtual functions such as igb_vf and i40e_vf require HW_CRC_STRIP to be explicitly enabled before configuration, otherwise device configuration will fail. This commit achieves this by adding NETDEV_RX_HW_CRC_STRIP to dpdk_hw_ol_features. When a dpdk device is added, the dri