Re: [ovs-dev] [PATCH v1] ofproto-dpif-xlate: fix zone set from non frozen metadata field

2021-02-18 Thread 贺鹏
Hi, I've already sent a v2 patch. Mark Gray 于2021年2月17日周三 下午6:44写道: > > On 17/02/2021 10:40, 贺鹏 wrote: > > Hi, > > > > Thanks for the review. > > > > Mark Gray 于2021年2月17日周三 下午6:13写道: > >> > >> I'm not too familiar with this code but I have some comments. > >> > >> On 15/02/2021 09:50, Peng He w

Re: [ovs-dev] [PATCH v1] ofproto-dpif-xlate: fix zone set from non frozen metadata field

2021-02-17 Thread Mark Gray
On 17/02/2021 10:40, 贺鹏 wrote: > Hi, > > Thanks for the review. > > Mark Gray 于2021年2月17日周三 下午6:13写道: >> >> I'm not too familiar with this code but I have some comments. >> >> On 15/02/2021 09:50, Peng He wrote: >>> CT zone could be set from a field that is not included in frozen >>> metedata. C

Re: [ovs-dev] [PATCH v1] ofproto-dpif-xlate: fix zone set from non frozen metadata field

2021-02-17 Thread 贺鹏
Hi, Thanks for the review. Mark Gray 于2021年2月17日周三 下午6:13写道: > > I'm not too familiar with this code but I have some comments. > > On 15/02/2021 09:50, Peng He wrote: > > CT zone could be set from a field that is not included in frozen > > metedata. Consider the belowing cases which is normally

Re: [ovs-dev] [PATCH v1] ofproto-dpif-xlate: fix zone set from non frozen metadata field

2021-02-17 Thread Mark Gray
I'm not too familiar with this code but I have some comments. On 15/02/2021 09:50, Peng He wrote: > CT zone could be set from a field that is not included in frozen > metedata. Consider the belowing cases which is normally used in Nits: s/metedata/metadata s/belowing cases which is/cases below w

Re: [ovs-dev] [PATCH v1] ofproto-dpif-xlate: fix zone set from non frozen metadata field

2021-02-15 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not a

[ovs-dev] [PATCH v1] ofproto-dpif-xlate: fix zone set from non frozen metadata field

2021-02-15 Thread Peng He
CT zone could be set from a field that is not included in frozen metedata. Consider the belowing cases which is normally used in OpenStack security group rules: priority=100,in_port=1,tcp,ct_state=-trk,action=ct(zone=5,table=0) priority=100,in_port=1,tcp,ct_state=+trk,action=ct(commit,zone=NXM_NX_