Re: [ovs-dev] [PATCH v1 1/2] ofproto-ipfix: use per-domain template timeouts

2023-01-17 Thread Adrian Moreno
On 1/16/23 21:00, Mike Pattrick wrote: On Mon, Jan 16, 2023 at 10:17 AM Adrián Moreno wrote: From: Adrian Moreno IPFIX templates have to be sent for each Observation Domain ID. Currently, a timer is kept at each dpif_ipfix_exporter to send them. This works fine for per-bridge sampling wher

Re: [ovs-dev] [PATCH v1 1/2] ofproto-ipfix: use per-domain template timeouts

2023-01-16 Thread Mike Pattrick
On Mon, Jan 16, 2023 at 10:17 AM Adrián Moreno wrote: > > From: Adrian Moreno > > IPFIX templates have to be sent for each Observation Domain ID. > Currently, a timer is kept at each dpif_ipfix_exporter to send them. > This works fine for per-bridge sampling where there is only one > Observation

Re: [ovs-dev] [PATCH v1 1/2] ofproto-ipfix: use per-domain template timeouts

2023-01-16 Thread 0-day Robot
Bleep bloop. Greetings Adrián Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #271 FILE: ofproto/ofproto-dpif-ipfix.c:2925: /* XX

[ovs-dev] [PATCH v1 1/2] ofproto-ipfix: use per-domain template timeouts

2023-01-16 Thread Adrián Moreno
From: Adrian Moreno IPFIX templates have to be sent for each Observation Domain ID. Currently, a timer is kept at each dpif_ipfix_exporter to send them. This works fine for per-bridge sampling where there is only one Observation Domain ID per exporter. However, this is does not work for per-flow