Re: [ovs-dev] [PATCH v1 2/6] dpif-netdev: add tunnel_valid flag to skip ip/ipv6 address comparison

2020-07-10 Thread Yanqin Wei
Hi Ilya, > > > >>> --- > >> > >> Hi. > >> First of all, thanks for working on performance improvements! > > Thanks, I saw some slides where OVS was used to compare flow scalability > with other projects. It inspired me to optimize this code. > > > >> > >> However, this doesn't look as a clean

Re: [ovs-dev] [PATCH v1 2/6] dpif-netdev: add tunnel_valid flag to skip ip/ipv6 address comparison

2020-07-09 Thread Ilya Maximets
On 7/6/20 1:27 PM, Yanqin Wei wrote: > Hi Ilya, > >>> --- >> >> Hi. >> First of all, thanks for working on performance improvements! > Thanks, I saw some slides where OVS was used to compare flow scalability with > other projects. It inspired me to optimize this code. > >> >> However, this

Re: [ovs-dev] [PATCH v1 2/6] dpif-netdev: add tunnel_valid flag to skip ip/ipv6 address comparison

2020-07-06 Thread Yanqin Wei
Hi Ilya, > > --- > > Hi. > First of all, thanks for working on performance improvements! Thanks, I saw some slides where OVS was used to compare flow scalability with other projects. It inspired me to optimize this code. > > However, this doesn't look as a clean patch. There are some

Re: [ovs-dev] [PATCH v1 2/6] dpif-netdev: add tunnel_valid flag to skip ip/ipv6 address comparison

2020-07-05 Thread Ilya Maximets
On 6/2/20 9:10 AM, Yanqin Wei wrote: > miniflow_extract checks the validation of tunnel metadata by comparing > tunnel destination address, including 16 bytes ipv6 address. > This patch introduces a 'tunnel_valid' flag. If it is false, > md->cacheline2 will not be touched. This improvement is

[ovs-dev] [PATCH v1 2/6] dpif-netdev: add tunnel_valid flag to skip ip/ipv6 address comparison

2020-06-02 Thread Yanqin Wei
miniflow_extract checks the validation of tunnel metadata by comparing tunnel destination address, including 16 bytes ipv6 address. This patch introduces a 'tunnel_valid' flag. If it is false, md->cacheline2 will not be touched. This improvement is beneficial to miniflow_extract performance for