Re: [ovs-dev] [PATCH v10 2/5] dpif-netdev: Count cycles on per-rxq basis.

2018-01-15 Thread Ilya Maximets
On 15.01.2018 12:27, Stokes, Ian wrote: >> +/* Update send cycles for all the rx queues evenly. */ > > Just a query, is it right that this is distributed evenly? > If there are more packets from one rx queue than another will it > make a difference or will the cycles spent s

Re: [ovs-dev] [PATCH v10 2/5] dpif-netdev: Count cycles on per-rxq basis.

2018-01-15 Thread Stokes, Ian
> > >>> +/* Update send cycles for all the rx queues evenly. */ > > >> > > >> Just a query, is it right that this is distributed evenly? > > >> If there are more packets from one rx queue than another will it > > >> make a difference or will the cycles spent sending that batch be > > >> the > >

Re: [ovs-dev] [PATCH v10 2/5] dpif-netdev: Count cycles on per-rxq basis.

2018-01-15 Thread Jan Scheurich
> >>> +/* Update send cycles for all the rx queues evenly. */ > >> > >> Just a query, is it right that this is distributed evenly? > >> If there are more packets from one rx queue than another will it make a > >> difference or will the cycles spent sending that batch be the > same as a batch o

Re: [ovs-dev] [PATCH v10 2/5] dpif-netdev: Count cycles on per-rxq basis.

2018-01-14 Thread Ilya Maximets
On 13.01.2018 17:42, Kevin Traynor wrote: > On 01/13/2018 12:16 PM, Stokes, Ian wrote: >> >> >>> -Original Message- >>> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >>> Sent: Friday, January 12, 2018 11:17 AM >>> To: ovs-dev@openvswitch.org >>> Cc: Heetae Ahn ; Bodireddy, Bhanuprakas

Re: [ovs-dev] [PATCH v10 2/5] dpif-netdev: Count cycles on per-rxq basis.

2018-01-13 Thread Kevin Traynor
On 01/13/2018 12:16 PM, Stokes, Ian wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Friday, January 12, 2018 11:17 AM >> To: ovs-dev@openvswitch.org >> Cc: Heetae Ahn ; Bodireddy, Bhanuprakash >> ; Fischetti, Antonio >> ; Eelco Chaudron ; >

Re: [ovs-dev] [PATCH v10 2/5] dpif-netdev: Count cycles on per-rxq basis.

2018-01-13 Thread Stokes, Ian
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, January 12, 2018 11:17 AM > To: ovs-dev@openvswitch.org > Cc: Heetae Ahn ; Bodireddy, Bhanuprakash > ; Fischetti, Antonio > ; Eelco Chaudron ; > Loftus, Ciara ; Kevin Traynor > ; Jan Scheurich ; O >

Re: [ovs-dev] [PATCH v10 2/5] dpif-netdev: Count cycles on per-rxq basis.

2018-01-12 Thread Ilya Maximets
On 12.01.2018 18:52, Jan Scheurich wrote: > Tested-by: Jan Scheurich > Acked-by: Jan Scheurich > > One minor comment inline. > > /Jan > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Friday, 12 January, 2018 12:17 >> To: ovs-dev@openvswitch.org >>

Re: [ovs-dev] [PATCH v10 2/5] dpif-netdev: Count cycles on per-rxq basis.

2018-01-12 Thread Jan Scheurich
Tested-by: Jan Scheurich Acked-by: Jan Scheurich One minor comment inline. /Jan > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, 12 January, 2018 12:17 > To: ovs-dev@openvswitch.org > Cc: Heetae Ahn ; Bhanuprakash Bodireddy > ; Antonio Fischet

[ovs-dev] [PATCH v10 2/5] dpif-netdev: Count cycles on per-rxq basis.

2018-01-12 Thread Ilya Maximets
Upcoming time-based output batching will allow to collect in a single output batch packets from different RX queues. Lets keep the list of RX queues for each output packet and collect cycles for them on send. Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 31 +--