Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-06-08 Thread Chris Mi
On 5/25/2021 7:19 PM, Eli Britstein wrote: On 5/19/2021 12:47 PM, Simon Horman wrote: External email: Use caution opening links or attachments On Tue, May 18, 2021 at 02:22:26PM +0200, Ilya Maximets wrote: On 4/27/21 3:23 AM, Chris Mi wrote: ... Hi Ilya, The code according to your sugges

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-05-25 Thread Eli Britstein
On 5/19/2021 12:47 PM, Simon Horman wrote: External email: Use caution opening links or attachments On Tue, May 18, 2021 at 02:22:26PM +0200, Ilya Maximets wrote: On 4/27/21 3:23 AM, Chris Mi wrote: ... Hi Ilya, The code according to your suggestion is ready. But during the internal code

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-05-19 Thread Simon Horman
On Tue, May 18, 2021 at 02:22:26PM +0200, Ilya Maximets wrote: > On 4/27/21 3:23 AM, Chris Mi wrote: ... > > Hi Ilya, > > > > The code according to your suggestion is ready. But during the internal > > code review, Eli Britstein thought flow_api is netdev based, but the > > psample/sFlow offload

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-05-18 Thread Ilya Maximets
On 4/27/21 3:23 AM, Chris Mi wrote: > On 3/24/2021 8:14 PM, Ilya Maximets wrote: >> On 3/24/21 10:17 AM, Chris Mi wrote: >>> On 3/23/2021 10:24 PM, Ilya Maximets wrote: On 3/5/21 4:27 AM, Chris Mi wrote: > Hi Ilya, > > I think about your suggestion recently. But I'm still not very

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-05-18 Thread Chris Mi
Hi Ilya, Could you please take a look if you have time? Thanks, Chris On 5/11/2021 4:11 PM, Chris Mi wrote: On 4/27/2021 9:23 AM, Chris Mi wrote: On 3/24/2021 8:14 PM, Ilya Maximets wrote: On 3/24/21 10:17 AM, Chris Mi wrote: On 3/23/2021 10:24 PM, Ilya Maximets wrote: On 3/5/21 4:27 AM, C

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-05-11 Thread Chris Mi
On 4/27/2021 9:23 AM, Chris Mi wrote: On 3/24/2021 8:14 PM, Ilya Maximets wrote: On 3/24/21 10:17 AM, Chris Mi wrote: On 3/23/2021 10:24 PM, Ilya Maximets wrote: On 3/5/21 4:27 AM, Chris Mi wrote: Hi Ilya, I think about your suggestion recently. But I'm still not very clear about the design

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-04-26 Thread Chris Mi
On 3/24/2021 8:14 PM, Ilya Maximets wrote: On 3/24/21 10:17 AM, Chris Mi wrote: On 3/23/2021 10:24 PM, Ilya Maximets wrote: On 3/5/21 4:27 AM, Chris Mi wrote: Hi Ilya, I think about your suggestion recently. But I'm still not very clear about the design. Please see my reply below: On 3/1/20

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-29 Thread Eelco Chaudron
On 24 Mar 2021, at 14:03, Chris Mi wrote: On 3/24/2021 8:14 PM, Ilya Maximets wrote: On 3/24/21 10:17 AM, Chris Mi wrote: On 3/23/2021 10:24 PM, Ilya Maximets wrote: On 3/5/21 4:27 AM, Chris Mi wrote: Hi Ilya, I think about your suggestion recently. But I'm still not very clear about the

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-24 Thread Chris Mi
On 3/24/2021 8:14 PM, Ilya Maximets wrote: On 3/24/21 10:17 AM, Chris Mi wrote: On 3/23/2021 10:24 PM, Ilya Maximets wrote: On 3/5/21 4:27 AM, Chris Mi wrote: Hi Ilya, I think about your suggestion recently. But I'm still not very clear about the design. Please see my reply below: On 3/1/20

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-24 Thread Ilya Maximets
On 3/24/21 10:17 AM, Chris Mi wrote: > On 3/23/2021 10:24 PM, Ilya Maximets wrote: >> On 3/5/21 4:27 AM, Chris Mi wrote: >>> Hi Ilya, >>> >>> I think about your suggestion recently. But I'm still not very clear about >>> the design. >>> Please see my reply below: >>> >>> On 3/1/2021 8:48 PM, Ilya

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-24 Thread Chris Mi
On 3/23/2021 10:24 PM, Ilya Maximets wrote: On 3/5/21 4:27 AM, Chris Mi wrote: Hi Ilya, I think about your suggestion recently. But I'm still not very clear about the design. Please see my reply below: On 3/1/2021 8:48 PM, Ilya Maximets wrote: On 3/1/21 9:30 AM, Chris Mi wrote: Hi Simon, Il

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-23 Thread Ilya Maximets
On 3/5/21 4:27 AM, Chris Mi wrote: > Hi Ilya, > > I think about your suggestion recently. But I'm still not very clear about > the design. > Please see my reply below: > > On 3/1/2021 8:48 PM, Ilya Maximets wrote: >> On 3/1/21 9:30 AM, Chris Mi wrote: >>> Hi Simon, Ilya, >>> >>> Could I know wha

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-04 Thread Chris Mi
Hi Ilya, I think about your suggestion recently. But I'm still not very clear about the design. Please see my reply below: On 3/1/2021 8:48 PM, Ilya Maximets wrote: On 3/1/21 9:30 AM, Chris Mi wrote: Hi Simon, Ilya, Could I know what should we do to make progress for this patch set? It has

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-01 Thread Chris Mi
On 3/1/2021 8:48 PM, Ilya Maximets wrote: On 3/1/21 9:30 AM, Chris Mi wrote: Hi Simon, Ilya, Could I know what should we do to make progress for this patch set? It has been posted in the community for a long time 😁 In general, the way to get your patches reviewed is to review other patches. I

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-01 Thread Ilya Maximets
On 3/1/21 9:30 AM, Chris Mi wrote: > Hi Simon, Ilya, > > Could I know what should we do to make progress for this patch set? > It has been posted in the community for a long time 😁 In general, the way to get your patches reviewed is to review other patches. It's simply because we still have a hu

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-01 Thread Chris Mi
Hi Simon, Ilya, Could I know what should we do to make progress for this patch set? It has been posted in the community for a long time 😁 Thanks, Chris On 2/23/2021 5:08 PM, Roi Dayan wrote: On 2021-01-27 8:23 AM, Chris Mi wrote: This patch set adds offload support for sFlow. Psample is a

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-02-23 Thread Eelco Chaudron
On 23 Feb 2021, at 12:11, Eelco Chaudron wrote: On 23 Feb 2021, at 10:08, Roi Dayan wrote: On 2021-01-27 8:23 AM, Chris Mi wrote: This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-02-23 Thread Eelco Chaudron
On 23 Feb 2021, at 10:08, Roi Dayan wrote: On 2021-01-27 8:23 AM, Chris Mi wrote: This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-02-23 Thread Roi Dayan
On 2021-01-27 8:23 AM, Chris Mi wrote: This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow ac

[ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-01-26 Thread Chris Mi
This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to k