[ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

Previous commits have added support to the dp_packet API to handle multi-segmented packets, where data is not stored contiguously in memory. However, in some cases, it is inevitable and data must be provided contiguously. Examples of such cases are when performing csums over the entire packet data,

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On Fri, Jan 11, 2019 at 1:43 AM Lam, Tiago wrote: > On 11/01/2019 01:34, Darrell Ball wrote: > > thanks; not a full review > > Thanks, responses in-line. > > > > > On Wed, Jan 9, 2019 at 10:06 AM Tiago Lam > > wrote: > > > > Previous commits have added support to

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

Hi, I will send another revision that addresses the concerns listed here. More specifically: - dp_packet_linearize() will only be called from process_one() in conntrack.c; - dp_packet_linearize() checks if a packet is linear by itself and exits earlier if so. That means other places in the code wi

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

Hello Tiago, On Thu, Jan 10, 2019 at 1:14 AM Tiago Lam wrote: > Previous commits have added support to the dp_packet API to handle > multi-segmented packets, where data is not stored contiguously in > memory. However, in some cases, it is inevitable and data must be > provided contiguously. Exam

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On Thu, Jan 10, 2019 at 10:11 AM David Marchand wrote: > This part triggers build (non fatal o_O) warnings on fedora 28. > Oops, important. This is when building without dpdk support. -- David Marchand ___ dev mailing list d...@openvswitch.org https

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On Thu, Jan 10, 2019 at 10:32 AM Lam, Tiago wrote: > On 10/01/2019 09:12, David Marchand wrote: > > On Thu, Jan 10, 2019 at 10:11 AM David Marchand > > mailto:david.march...@redhat.com>> wrote: > > > > This part triggers build (non fatal o_O) warnings on fedora 28. > > > > > > Oops, important

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On 10/01/2019 09:41, David Marchand wrote: > > On Thu, Jan 10, 2019 at 10:32 AM Lam, Tiago > wrote: > > On 10/01/2019 09:12, David Marchand wrote: > > On Thu, Jan 10, 2019 at 10:11 AM David Marchand > > mailto:david.march...@redhat.com> >

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On 10/01/2019 09:12, David Marchand wrote: > On Thu, Jan 10, 2019 at 10:11 AM David Marchand > mailto:david.march...@redhat.com>> wrote: > > This part triggers build (non fatal o_O) warnings on fedora 28. > > > Oops, important. > This is when building without dpdk support. Hi David, Thanks

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

thanks; not a full review On Wed, Jan 9, 2019 at 10:06 AM Tiago Lam wrote: > Previous commits have added support to the dp_packet API to handle > multi-segmented packets, where data is not stored contiguously in > memory. However, in some cases, it is inevitable and data must be > provided conti

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On 11/01/2019 01:34, Darrell Ball wrote: > thanks; not a full review Thanks, responses in-line. > > On Wed, Jan 9, 2019 at 10:06 AM Tiago Lam > wrote: > > Previous commits have added support to the dp_packet API to handle > multi-segmented packets, where dat

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

Not a full review. Comments inline. Best regards, Ilya Maximets. On 09.01.2019 21:05, Tiago Lam wrote: > Previous commits have added support to the dp_packet API to handle > multi-segmented packets, where data is not stored contiguously in > memory. However, in some cases, it is inevitable and da

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On 11/01/2019 11:29, Ilya Maximets wrote: > Not a full review. > Comments inline. Thanks Ilya, responses in-line. > > Best regards, Ilya Maximets. > > On 09.01.2019 21:05, Tiago Lam wrote: >> Previous commits have added support to the dp_packet API to handle >> multi-segmented packets, where da