Re: [ovs-dev] [PATCH v2] Monitor Database table to manage lifecycle of IDL client.

2019-01-16 Thread Ted Elhourani
Sure, I fixed and verified with “make flake8-check”. Ted > On Jan 16, 2019, at 12:29 PM, Ben Pfaff wrote: > > On Fri, Jan 04, 2019 at 02:16:36AM +, Ted Elhourani wrote: >> The Python IDL implementation supports ovsdb cluster connections. >> This patch is a follow up to commit 31e434fc98, it

Re: [ovs-dev] [PATCH v2] Monitor Database table to manage lifecycle of IDL client.

2019-01-16 Thread Ben Pfaff
On Fri, Jan 04, 2019 at 02:16:36AM +, Ted Elhourani wrote: > The Python IDL implementation supports ovsdb cluster connections. > This patch is a follow up to commit 31e434fc98, it adds the option of > connecting to the leader (the default) in the Raft-based cluster. It mimics > the exisiting C

Re: [ovs-dev] [PATCH v2] Monitor Database table to manage lifecycle of IDL client.

2019-01-16 Thread Ted Elhourani
Hi Numan, Thanks for the review, please find responses inline. Ted On Jan 11, 2019, at 2:23 AM, Numan Siddique mailto:nusid...@redhat.com>> wrote: On Fri, Jan 4, 2019 at 5:26 PM Numan Siddique mailto:nusid...@redhat.com>> wrote: Hi Ted, This patch is failing the below test cases for me.

Re: [ovs-dev] [PATCH v2] Monitor Database table to manage lifecycle of IDL client.

2019-01-11 Thread Numan Siddique
On Fri, Jan 4, 2019 at 5:26 PM Numan Siddique wrote: > Hi Ted, > > This patch is failing the below test cases for me. All are python3 > related. Can you please > take a look if that's the case with you as well ? > ** > 2139: simple idl, writing via IDL with unicode - Python3 FAILED ( >

Re: [ovs-dev] [PATCH v2] Monitor Database table to manage lifecycle of IDL client.

2019-01-04 Thread Numan Siddique
Hi Ted, This patch is failing the below test cases for me. All are python3 related. Can you please take a look if that's the case with you as well ? ** 2139: simple idl, writing via IDL with unicode - Python3 FAILED ( ovsdb-idl.at:456) 2141: simple idl, writing via IDL with unicode - Python3

[ovs-dev] [PATCH v2] Monitor Database table to manage lifecycle of IDL client.

2019-01-03 Thread Ted Elhourani
The Python IDL implementation supports ovsdb cluster connections. This patch is a follow up to commit 31e434fc98, it adds the option of connecting to the leader (the default) in the Raft-based cluster. It mimics the exisiting C IDL support for clusters introduced in commit 1b1d2e6daa. The _Server