Re: [ovs-dev] [PATCH v2] checkpatch: Normalize exit code for Windows

2019-03-13 Thread aserdean
> > because of: > > ./checkpatch.at:32: exit code was 0, expected 255 > > > > This patch introduces a positive constant for the default exit code. > > > > Signed-off-by: Alin Gabriel Serdean > > Acked-by: Ben Pfaff > > Acked-by: Aaron Conole > > I'm pretty sure that this is just for exit on fa

Re: [ovs-dev] [PATCH v2] checkpatch: Normalize exit code for Windows

2019-02-11 Thread Ben Pfaff
On Mon, Feb 11, 2019 at 05:57:27PM +0200, Alin Gabriel Serdean wrote: > Using python `sys.exit(-1)` on Windows produces mixed results. > Let's take the following results from different shells: > CMD > >python -c "import sys; sys.exit(-1)" & echo %errorlevel% > 1 > MSYS > $ python -c "import sys; sy

[ovs-dev] [PATCH v2] checkpatch: Normalize exit code for Windows

2019-02-11 Thread Alin Gabriel Serdean
Using python `sys.exit(-1)` on Windows produces mixed results. Let's take the following results from different shells: CMD >python -c "import sys; sys.exit(-1)" & echo %errorlevel% 1 MSYS $ python -c "import sys; sys.exit(-1)" && echo $? 0 WSL $ python -c "import sys; sys.exit(-1)"; echo $? 255 th