Re: [ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

2020-08-17 Thread Ilya Maximets
On 8/12/20 10:07 PM, Aaron Conole wrote: > When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive > connections more uniform") was applied, it did not take into account > that a reconfiguration of the allowed_versions setting would require a > reload of the ofservice object (only

Re: [ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

2020-08-12 Thread Numan Siddique
On Thu, Aug 13, 2020 at 1:55 AM Flavio Leitner wrote: > > On Wed, Aug 12, 2020 at 04:07:55PM -0400, Aaron Conole wrote: > > When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive > > connections more uniform") was applied, it did not take into account > > that a reconfiguration

Re: [ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

2020-08-12 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 109 characters long (recommended limit is 79) #49 FILE:

Re: [ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

2020-08-12 Thread Flavio Leitner
On Wed, Aug 12, 2020 at 04:07:55PM -0400, Aaron Conole wrote: > When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive > connections more uniform") was applied, it did not take into account > that a reconfiguration of the allowed_versions setting would require a > reload of the

[ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

2020-08-12 Thread Aaron Conole
When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive connections more uniform") was applied, it did not take into account that a reconfiguration of the allowed_versions setting would require a reload of the ofservice object (only accomplished via a restart of OvS). For now,