[ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2022-12-14 Thread wushaohua
From: wushaohua The icmp_id maybe conflicts in snat Description: If multiple devices send icmp packets with the same icmp_id, the sip of the packets changes to the same source ip address after the snat operation, and the packets are sent to the same destination ip address. Only one ct entry is c

[ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-07-02 Thread wushaohua
From: Shaohua Wu The icmp_id maybe conflicts in snat Description: If multiple devices send icmp packets with the same icmp_id, the sip of the packets changes to the same source ip address after the snat operation, and the packets are sent to the same destination ip address. Only one ct entry is

[ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-07-02 Thread wushaohua
From: Shaohua Wu The icmp_id maybe conflicts in snat Description: If multiple devices send icmp packets with the same icmp_id, the sip of the packets changes to the same source ip address after the snat operation, and the packets are sent to the same destination ip address. Only one ct entry is

Re: [ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-07-02 Thread wushao...@chinatelecom.cn
Hi Mike, Thank you for your review. I have followed your advice and added unit tests as suggested. Best wishes shaohua From: Mike Pattrick Date: 2023-06-06 03:18 To: wushaohua CC: dev; ctyun-rd1-INF-Network Subject: Re: [ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat On Wed

Re: [ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-07-04 Thread Ilya Maximets
On 7/2/23 17:19, wushao...@chinatelecom.cn wrote: > From: Shaohua Wu > > The icmp_id maybe conflicts in snat > Description: > If multiple devices send icmp packets with the same icmp_id, > the sip of the packets changes to the same source ip address after the snat > operation, > and the packets

Re: [ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-07-06 Thread Aaron Conole
Hi Shaohua, Some nits as well (before you send v3). I will review the code in v3. wushao...@chinatelecom.cn writes: > From: Shaohua Wu > > The icmp_id maybe conflicts in snat > Description: > If multiple devices send icmp packets with the same icmp_id, > the sip of the packets changes to the s

Re: [ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-06-05 Thread Mike Pattrick
On Wed, Dec 14, 2022 at 10:50 PM wrote: > > From: wushaohua > > The icmp_id maybe conflicts in snat > Description: > If multiple devices send icmp packets with the same icmp_id, > the sip of the packets changes to the same source ip address after the snat > operation, > and the packets are sent