Re: [ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-16 Thread Pravin Shelar
On Fri, Nov 13, 2020 at 4:06 AM Ilya Maximets wrote: > > On 11/13/20 11:04 AM, Eelco Chaudron wrote: > > Add support for the dec_ttl action. Instead of programming the datapath with > > a flow that matches the packet TTL and an IP set, use a single dec_ttl > > action. > > > > The old behavior is

Re: [ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-16 Thread Eelco Chaudron
On 13 Nov 2020, at 17:05, Ilya Maximets wrote: Cc: netdev On 11/13/20 3:28 PM, Eelco Chaudron wrote: On 13 Nov 2020, at 13:06, Ilya Maximets wrote: On 11/13/20 11:04 AM, Eelco Chaudron wrote: Add support for the dec_ttl action. Instead of programming the datapath with a flow that

Re: [ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-13 Thread Ilya Maximets
Cc: netdev On 11/13/20 3:28 PM, Eelco Chaudron wrote: > > > On 13 Nov 2020, at 13:06, Ilya Maximets wrote: > >> On 11/13/20 11:04 AM, Eelco Chaudron wrote: >>> Add support for the dec_ttl action. Instead of programming the datapath with >>> a flow that matches the packet TTL and an IP set, use

Re: [ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-13 Thread Eelco Chaudron
On 13 Nov 2020, at 13:53, Ilya Maximets wrote: On 11/13/20 11:04 AM, Eelco Chaudron wrote: Add support for the dec_ttl action. Instead of programming the datapath with a flow that matches the packet TTL and an IP set, use a single dec_ttl action. The old behavior is kept if the new action

Re: [ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-13 Thread Matteo Croce
On Fri, Nov 13, 2020 at 3:28 PM Eelco Chaudron wrote: > > It is already in the mainline kernel, so changing it now would break the > UAPI. Don't think this is allowed from the kernel side. > > > What I'm suggesting is to send a bugfix to kernel > > to accept only format with nested

Re: [ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-13 Thread Eelco Chaudron
On 13 Nov 2020, at 13:06, Ilya Maximets wrote: On 11/13/20 11:04 AM, Eelco Chaudron wrote: Add support for the dec_ttl action. Instead of programming the datapath with a flow that matches the packet TTL and an IP set, use a single dec_ttl action. The old behavior is kept if the new

Re: [ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-13 Thread Ilya Maximets
On 11/13/20 11:04 AM, Eelco Chaudron wrote: > Add support for the dec_ttl action. Instead of programming the datapath with > a flow that matches the packet TTL and an IP set, use a single dec_ttl action. > > The old behavior is kept if the new action is not supported by the datapath. > > #

Re: [ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-13 Thread Ilya Maximets
On 11/13/20 11:04 AM, Eelco Chaudron wrote: > Add support for the dec_ttl action. Instead of programming the datapath with > a flow that matches the packet TTL and an IP set, use a single dec_ttl action. > > The old behavior is kept if the new action is not supported by the datapath. > > #

Re: [ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-13 Thread 0-day Robot
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include

[ovs-dev] [PATCH v2] datapath: Add a new action dec_ttl

2020-11-13 Thread Eelco Chaudron
Add support for the dec_ttl action. Instead of programming the datapath with a flow that matches the packet TTL and an IP set, use a single dec_ttl action. The old behavior is kept if the new action is not supported by the datapath. # ovs-ofctl dump-flows br0 cookie=0x0, duration=12.538s,