Re: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

2017-08-17 Thread aserdean
[mailto:ovs-dev- > > boun...@openvswitch.org] On Behalf Of Anand Kumar > > Sent: Wednesday, August 16, 2017 1:29 AM > > To: d...@openvswitch.org > > Subject: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port > > field for ICMP during SNAT/DNAT > > > > Dur

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

2017-08-17 Thread Alin Serdean
> Subject: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port field > for ICMP during SNAT/DNAT > > During SNAT/DNAT, we should not be updating the port field of ct_endpoint > struct, as ICMP packets do not have port information. Since port and icmp_id > are overlapped in

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

2017-08-17 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar Sent: Tuesday, August 15, 2017 3:29 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT During SNAT/DNAT, we

[ovs-dev] [PATCH v2] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

2017-08-15 Thread Anand Kumar
During SNAT/DNAT, we should not be updating the port field of ct_endpoint struct, as ICMP packets do not have port information. Since port and icmp_id are overlapped in ct_endpoint struct, icmp_id gets changed. As a result, NAT look up fails to find a matching entry. This patch addresses this issu