Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-16 Thread Ilya Maximets
On 7/15/20 6:00 PM, Ilya Maximets wrote: > Main thread will try to pause/stop all revalidators during datapath > reconfiguration via datapath purge callback (dp_purge_cb) while > holding 'dp->port_mutex'. And deadlock happens in case any of > revalidator threads is already waiting on

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-16 Thread Eli Britstein
Tested-by: Eli Britstein I was able to reproduce (saw by gdb the points in the deadlock). Fixed by this commit. On 7/16/2020 3:20 PM, Ilya Maximets wrote: On 7/16/20 12:25 PM, Sriharsha Basavapatna wrote: On Thu, Jul 16, 2020 at 2:52 PM Ilya Maximets wrote: On 7/16/20 10:01 AM, Eli

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-16 Thread Ilya Maximets
On 7/16/20 12:25 PM, Sriharsha Basavapatna wrote: > On Thu, Jul 16, 2020 at 2:52 PM Ilya Maximets wrote: >> >> On 7/16/20 10:01 AM, Eli Britstein wrote: >>> >>> On 7/16/2020 1:37 AM, Ilya Maximets wrote: On 7/15/20 8:30 PM, Stokes, Ian wrote: >> On 15/07/2020 17:00, Ilya Maximets wrote:

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-16 Thread Sriharsha Basavapatna via dev
On Thu, Jul 16, 2020 at 2:52 PM Ilya Maximets wrote: > > On 7/16/20 10:01 AM, Eli Britstein wrote: > > > > On 7/16/2020 1:37 AM, Ilya Maximets wrote: > >> On 7/15/20 8:30 PM, Stokes, Ian wrote: > On 15/07/2020 17:00, Ilya Maximets wrote: > > Main thread will try to pause/stop all

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-16 Thread Ilya Maximets
On 7/16/20 10:01 AM, Eli Britstein wrote: > > On 7/16/2020 1:37 AM, Ilya Maximets wrote: >> On 7/15/20 8:30 PM, Stokes, Ian wrote: On 15/07/2020 17:00, Ilya Maximets wrote: > Main thread will try to pause/stop all revalidators during datapath > reconfiguration via datapath purge

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-16 Thread Eli Britstein
On 7/16/2020 1:37 AM, Ilya Maximets wrote: On 7/15/20 8:30 PM, Stokes, Ian wrote: On 15/07/2020 17:00, Ilya Maximets wrote: Main thread will try to pause/stop all revalidators during datapath reconfiguration via datapath purge callback (dp_purge_cb) while holding 'dp->port_mutex'. And

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-15 Thread Ilya Maximets
On 7/15/20 8:30 PM, Stokes, Ian wrote: >> >> On 15/07/2020 17:00, Ilya Maximets wrote: >>> Main thread will try to pause/stop all revalidators during datapath >>> reconfiguration via datapath purge callback (dp_purge_cb) while >>> holding 'dp->port_mutex'. And deadlock happens in case any of >>>

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-15 Thread Stokes, Ian
> > On 15/07/2020 17:00, Ilya Maximets wrote: > > Main thread will try to pause/stop all revalidators during datapath > > reconfiguration via datapath purge callback (dp_purge_cb) while > > holding 'dp->port_mutex'. And deadlock happens in case any of > > revalidator threads is already waiting

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-15 Thread 0-day Robot
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #172 FILE: lib/dpif-netdev.c:3365: * XXX: Main thread

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-15 Thread Kevin Traynor
On 15/07/2020 17:00, Ilya Maximets wrote: > Main thread will try to pause/stop all revalidators during datapath > reconfiguration via datapath purge callback (dp_purge_cb) while > holding 'dp->port_mutex'. And deadlock happens in case any of > revalidator threads is already waiting on

[ovs-dev] [PATCH v2] dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.

2020-07-15 Thread Ilya Maximets
Main thread will try to pause/stop all revalidators during datapath reconfiguration via datapath purge callback (dp_purge_cb) while holding 'dp->port_mutex'. And deadlock happens in case any of revalidator threads is already waiting on 'dp->port_mutex' while dumping offloaded flows: