Re: [ovs-dev] [PATCH v2] lldp: fix bugs when parsing malformed AutoAttach

2022-12-20 Thread Aaron Conole
Ilya Maximets writes: > On 12/20/22 15:36, Aaron Conole wrote: >> The OVS LLDP implementation includes support for AutoAttach standard, which >> the 'upstream' lldpd project does not include. As part of adding this >> support, the message parsing for these TLVs did not include proper length >>

Re: [ovs-dev] [PATCH v2] lldp: fix bugs when parsing malformed AutoAttach

2022-12-20 Thread Ilya Maximets
On 12/20/22 15:36, Aaron Conole wrote: > The OVS LLDP implementation includes support for AutoAttach standard, which > the 'upstream' lldpd project does not include. As part of adding this > support, the message parsing for these TLVs did not include proper length > checks for the

Re: [ovs-dev] [PATCH v2] lldp: fix bugs when parsing malformed AutoAttach

2022-12-20 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author should not be also be co-author. Lines checked: 80, Warnings: 0, Errors: 1

[ovs-dev] [PATCH v2] lldp: fix bugs when parsing malformed AutoAttach

2022-12-20 Thread Aaron Conole
The OVS LLDP implementation includes support for AutoAttach standard, which the 'upstream' lldpd project does not include. As part of adding this support, the message parsing for these TLVs did not include proper length checks for the LLDP_TLV_AA_ELEMENT_SUBTYPE and the