Re: [ovs-dev] [PATCH v2] net: openvswitch: introduce common code for flushing flows

2020-08-17 Thread Johan Knöös via dev
On Sat, Aug 15, 2020 at 12:48 AM Tonghao Zhang wrote: > > On Sat, Aug 15, 2020 at 3:28 AM Johan Knöös wrote: > > > > On Thu, Aug 13, 2020 at 3:53 PM David Miller wrote: > > > > > > From: xiangxia.m@gmail.com > > > Date: Wed, 12 Aug 2020 17:56:39 +0800 > > > > > > > From: Tonghao Zhang > >

Re: [ovs-dev] [PATCH v2] net: openvswitch: introduce common code for flushing flows

2020-08-15 Thread Tonghao Zhang
On Sat, Aug 15, 2020 at 3:28 AM Johan Knöös wrote: > > On Thu, Aug 13, 2020 at 3:53 PM David Miller wrote: > > > > From: xiangxia.m@gmail.com > > Date: Wed, 12 Aug 2020 17:56:39 +0800 > > > > > From: Tonghao Zhang > > > > > > To avoid some issues, for example RCU usage warning and double

Re: [ovs-dev] [PATCH v2] net: openvswitch: introduce common code for flushing flows

2020-08-14 Thread Johan Knöös via dev
On Thu, Aug 13, 2020 at 3:53 PM David Miller wrote: > > From: xiangxia.m@gmail.com > Date: Wed, 12 Aug 2020 17:56:39 +0800 > > > From: Tonghao Zhang > > > > To avoid some issues, for example RCU usage warning and double free, > > we should flush the flows under ovs_lock. This patch refactors

Re: [ovs-dev] [PATCH v2] net: openvswitch: introduce common code for flushing flows

2020-08-13 Thread David Miller
From: xiangxia.m@gmail.com Date: Wed, 12 Aug 2020 17:56:39 +0800 > From: Tonghao Zhang > > To avoid some issues, for example RCU usage warning and double free, > we should flush the flows under ovs_lock. This patch refactors > table_instance_destroy and introduces table_instance_flow_flush

Re: [ovs-dev] [PATCH v2] net: openvswitch: introduce common code for flushing flows

2020-08-13 Thread Cong Wang
On Wed, Aug 12, 2020 at 2:59 AM wrote: > > From: Tonghao Zhang > > To avoid some issues, for example RCU usage warning and double free, > we should flush the flows under ovs_lock. This patch refactors > table_instance_destroy and introduces table_instance_flow_flush > which can be invoked by

[ovs-dev] [PATCH v2] net: openvswitch: introduce common code for flushing flows

2020-08-12 Thread xiangxia . m . yue
From: Tonghao Zhang To avoid some issues, for example RCU usage warning and double free, we should flush the flows under ovs_lock. This patch refactors table_instance_destroy and introduces table_instance_flow_flush which can be invoked by __dp_destroy or ovs_flow_tbl_flush. Fixes: 50b0e61b32ee