Re: [ovs-dev] [PATCH v2] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2022-09-20 Thread David Marchand
On Wed, Sep 14, 2022 at 5:14 PM Mike Pattrick wrote: > > On Tue, Sep 13, 2022 at 5:21 AM David Marchand > wrote: > > > > At some point in OVS history, some virtio features were announced as > > supported (ECN and UFO virtio features). > > > > The userspace TSO code, which has been added later, do

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2022-09-14 Thread Mike Pattrick
On Tue, Sep 13, 2022 at 5:21 AM David Marchand wrote: > > At some point in OVS history, some virtio features were announced as > supported (ECN and UFO virtio features). > > The userspace TSO code, which has been added later, does not support > those features and tries to disable them. > > This br

[ovs-dev] [PATCH v2] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2022-09-13 Thread David Marchand
At some point in OVS history, some virtio features were announced as supported (ECN and UFO virtio features). The userspace TSO code, which has been added later, does not support those features and tries to disable them. This breaks OVS upgrades: if an existing VM already negotiated such features