Re: [ovs-dev] [PATCH v2] netdev-linux: Ignore TSO packets when TSO is not enabled for userspace

2021-07-10 Thread Flavio Leitner
On Fri, Jul 09, 2021 at 10:08:39PM +0200, Ilya Maximets wrote: > On 7/8/21 2:16 PM, Flavio Leitner wrote: > > On Mon, Jul 05, 2021 at 07:57:41AM -0400, Eelco Chaudron wrote: > >> When TSO is disabled from a userspace forwarding datapath perspective, > >> but TSO has been wrongly enabled on the

Re: [ovs-dev] [PATCH v2] netdev-linux: Ignore TSO packets when TSO is not enabled for userspace

2021-07-09 Thread Ilya Maximets
On 7/8/21 2:16 PM, Flavio Leitner wrote: > > Hi Ian, > > This one affects TSO which I think you have interest. > > If you're okay with the patch, could you please merge it? I applied it. > > Thanks, > fbl > > On Mon, Jul 05, 2021 at 07:57:41AM -0400, Eelco Chaudron wrote: >> When TSO is

Re: [ovs-dev] [PATCH v2] netdev-linux: Ignore TSO packets when TSO is not enabled for userspace

2021-07-08 Thread Flavio Leitner
Hi Ian, This one affects TSO which I think you have interest. If you're okay with the patch, could you please merge it? Thanks, fbl On Mon, Jul 05, 2021 at 07:57:41AM -0400, Eelco Chaudron wrote: > When TSO is disabled from a userspace forwarding datapath perspective, > but TSO has been

Re: [ovs-dev] [PATCH v2] netdev-linux: Ignore TSO packets when TSO is not enabled for userspace

2021-07-05 Thread Flavio Leitner
On Mon, Jul 05, 2021 at 07:57:41AM -0400, Eelco Chaudron wrote: > When TSO is disabled from a userspace forwarding datapath perspective, > but TSO has been wrongly enabled on the kernel side, log a warning > message, and drop the packet. With the current implementation, > OVS will crash. > >

[ovs-dev] [PATCH v2] netdev-linux: Ignore TSO packets when TSO is not enabled for userspace

2021-07-05 Thread Eelco Chaudron
When TSO is disabled from a userspace forwarding datapath perspective, but TSO has been wrongly enabled on the kernel side, log a warning message, and drop the packet. With the current implementation, OVS will crash. Fixes: 73858f9db ("netdev-linux: Prepend the std packet in the TSO packet")