Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-29 Thread Tao Liu
On Mon, Jun 27, 2022 at 03:47:34PM +0300, Roi Dayan wrote: > > could it be your bond0 configuration? > beside doing +bond0 into /sys/class/net/bonding_masters how do you > config bond0 and its slave? > > I don't have any static config file and use ip commands > as follows: > > ip link add name b

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-27 Thread Roi Dayan via dev
On 2022-06-27 1:13 PM, Tao Liu wrote: On Mon, Jun 27, 2022 at 11:51:48AM +0300, Roi Dayan wrote: On 2022-06-27 10:49 AM, Tao Liu wrote: On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote: On 2022-06-23 12:42 PM, Roi Dayan wrote: On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner w

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-27 Thread Tao Liu
On Mon, Jun 27, 2022 at 11:51:48AM +0300, Roi Dayan wrote: > > > On 2022-06-27 10:49 AM, Tao Liu wrote: > > On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote: > > > > > > > > > On 2022-06-23 12:42 PM, Roi Dayan wrote: > > > > > > > > > > > > On 2022-06-22 11:56 PM, Marcelo Ricardo Lei

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-27 Thread Roi Dayan via dev
On 2022-06-27 10:49 AM, Tao Liu wrote: On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote: On 2022-06-23 12:42 PM, Roi Dayan wrote: On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner wrote: On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote: On Tue, Jun 21, 2022 at 06:49:42AM -

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-27 Thread Tao Liu
On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote: > > > On 2022-06-23 12:42 PM, Roi Dayan wrote: > > > > > > On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner wrote: > > > On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote: > > > > On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo R

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-26 Thread Roi Dayan via dev
On 2022-06-23 12:42 PM, Roi Dayan wrote: On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner wrote: On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote: On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo Ricardo Leitner wrote: Hi, On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote: B

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-23 Thread Roi Dayan via dev
On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner wrote: On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote: On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo Ricardo Leitner wrote: Hi, On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote: Bond master netdev may be created without a

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-22 Thread Marcelo Ricardo Leitner
On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote: > On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo Ricardo Leitner wrote: > > Hi, > > > > On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote: > > > Bond master netdev may be created without a classification type, due > > > to routing or

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-21 Thread Tao Liu
On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo Ricardo Leitner wrote: > Hi, > > On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote: > > Bond master netdev may be created without a classification type, due > > to routing or tunneling code. > > Can you please elaborate on why is this an iss

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-21 Thread Marcelo Ricardo Leitner
Hi, On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote: > Bond master netdev may be created without a classification type, due > to routing or tunneling code. Can you please elaborate on why is this an issue? > > If bond master is not attached to ovs, the ingress block on slaves shoud > not

[ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-20 Thread Tao Liu
Bond master netdev may be created without a classification type, due to routing or tunneling code. If bond master is not attached to ovs, the ingress block on slaves shoud not be updated. Simple reproducer: ip a add 10.1.1.1/30 dev bond0 ip l set net3 master bond0 tc q ls dev net3 Fixes: d