Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Reject install rules for tc flower unsupported ct_state flags

2021-02-03 Thread Ilya Maximets
On 2/3/21 1:09 PM, Marcelo Ricardo Leitner wrote: > On Wed, Feb 03, 2021 at 01:30:00PM +0800, we...@ucloud.cn wrote: > ... >> @@ -1641,6 +1644,10 @@ netdev_tc_flow_put(struct netdev *netdev, struct >> match *match, >> } >> >> if (mask->ct_state) { >> +if (mask->ct_state & TC_UN

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Reject install rules for tc flower unsupported ct_state flags

2021-02-03 Thread Marcelo Ricardo Leitner
On Wed, Feb 03, 2021 at 01:30:00PM +0800, we...@ucloud.cn wrote: ... > @@ -1641,6 +1644,10 @@ netdev_tc_flow_put(struct netdev *netdev, struct match > *match, > } > > if (mask->ct_state) { > +if (mask->ct_state & TC_UNSUPP_OVS_CS_FLAGS) { > +return EOPNOTSUPP; > +

[ovs-dev] [PATCH v2] netdev-offload-tc: Reject install rules for tc flower unsupported ct_state flags

2021-02-02 Thread wenxu
From: wenxu TC flower doesn't support the INVALID/SNAT/DNAT/REPLY ct state flag. So it is better to reject this rule. Signed-off-by: wenxu --- lib/netdev-offload-tc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index 586d99d..587