Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: Don't offload header modification on ip fragments.

On 2 Jul 2024, at 15:38, Ilya Maximets wrote: > On 6/27/24 15:03, Eelco Chaudron wrote: >> >> >> On 4 Jun 2024, at 13:52, Ilya Maximets wrote: >> >>> On 6/4/24 13:42, Eelco Chaudron wrote: On 1 Jun 2024, at 0:08, Ilya Maximets wrote: > On 5/7/24 15:52, Eelco Chaudron wrot

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: Don't offload header modification on ip fragments.

On 6/27/24 15:03, Eelco Chaudron wrote: > > > On 4 Jun 2024, at 13:52, Ilya Maximets wrote: > >> On 6/4/24 13:42, Eelco Chaudron wrote: >>> >>> >>> On 1 Jun 2024, at 0:08, Ilya Maximets wrote: >>> On 5/7/24 15:52, Eelco Chaudron wrote: > While offloading header modifications to TC, OVS

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: Don't offload header modification on ip fragments.

On 4 Jun 2024, at 13:52, Ilya Maximets wrote: > On 6/4/24 13:42, Eelco Chaudron wrote: >> >> >> On 1 Jun 2024, at 0:08, Ilya Maximets wrote: >> >>> On 5/7/24 15:52, Eelco Chaudron wrote: While offloading header modifications to TC, OVS is using {TCA_PEDIT} + {TCA_CSUM} combination as

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: Don't offload header modification on ip fragments.

On 4 Jun 2024, at 13:52, Ilya Maximets wrote: > On 6/4/24 13:42, Eelco Chaudron wrote: >> >> >> On 1 Jun 2024, at 0:08, Ilya Maximets wrote: >> >>> On 5/7/24 15:52, Eelco Chaudron wrote: While offloading header modifications to TC, OVS is using {TCA_PEDIT} + {TCA_CSUM} combination as t

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: Don't offload header modification on ip fragments.

On 6/4/24 13:42, Eelco Chaudron wrote: > > > On 1 Jun 2024, at 0:08, Ilya Maximets wrote: > >> On 5/7/24 15:52, Eelco Chaudron wrote: >>> While offloading header modifications to TC, OVS is using {TCA_PEDIT} + >>> {TCA_CSUM} combination as that it the only way to represent header >>> rewrite. H

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: Don't offload header modification on ip fragments.

On 1 Jun 2024, at 0:08, Ilya Maximets wrote: > On 5/7/24 15:52, Eelco Chaudron wrote: >> While offloading header modifications to TC, OVS is using {TCA_PEDIT} + >> {TCA_CSUM} combination as that it the only way to represent header >> rewrite. However, {TCA_CSUM} is unable to calculate L4 check

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: Don't offload header modification on ip fragments.

On 5/7/24 15:52, Eelco Chaudron wrote: > While offloading header modifications to TC, OVS is using {TCA_PEDIT} + > {TCA_CSUM} combination as that it the only way to represent header > rewrite. However, {TCA_CSUM} is unable to calculate L4 checksums for > IP fragments. > > Since TC already applies

[ovs-dev] [PATCH v2] netdev-tc-offloads: Don't offload header modification on ip fragments.

While offloading header modifications to TC, OVS is using {TCA_PEDIT} + {TCA_CSUM} combination as that it the only way to represent header rewrite. However, {TCA_CSUM} is unable to calculate L4 checksums for IP fragments. Since TC already applies fragmentation bit masking, this patch simply needs