Re: [ovs-dev] [PATCH v2] odp-util: Use flexible sized buffer to hold Geneve options.

2019-03-18 Thread Ben Pfaff
On Mon, Mar 18, 2019 at 07:13:27PM +0300, Ilya Maximets wrote: > > On Thu, Dec 21, 2017 at 04:30:05PM -0800, Justin Pettit wrote: > >> > >> > >> > On Dec 4, 2017, at 11:51 AM, Ben Pfaff wrote: > >> > > >> > The 'mask' buffer in parse_odp_action() is supposed to always be big > >> > enough: >

Re: [ovs-dev] [PATCH v2] odp-util: Use flexible sized buffer to hold Geneve options.

2019-03-18 Thread Simon Horman
On Mon, Mar 18, 2019 at 07:13:27PM +0300, Ilya Maximets wrote: > > On Thu, Dec 21, 2017 at 04:30:05PM -0800, Justin Pettit wrote: > >> > >> > >> > On Dec 4, 2017, at 11:51 AM, Ben Pfaff wrote: > >> > > >> > The 'mask' buffer in parse_odp_action() is supposed to always be big > >> > enough: >

Re: [ovs-dev] [PATCH v2] odp-util: Use flexible sized buffer to hold Geneve options.

2019-03-18 Thread Ilya Maximets
> On Thu, Dec 21, 2017 at 04:30:05PM -0800, Justin Pettit wrote: >> >> >> > On Dec 4, 2017, at 11:51 AM, Ben Pfaff wrote: >> > >> > The 'mask' buffer in parse_odp_action() is supposed to always be big >> > enough: >> >/* 'mask' is big enough to hold any key. */ >> > >> > Geneve

Re: [ovs-dev] [PATCH v2] odp-util: Use flexible sized buffer to hold Geneve options.

2017-12-22 Thread Ben Pfaff
On Thu, Dec 21, 2017 at 04:30:05PM -0800, Justin Pettit wrote: > > > > On Dec 4, 2017, at 11:51 AM, Ben Pfaff wrote: > > > > The 'mask' buffer in parse_odp_action() is supposed to always be big > > enough: > >/* 'mask' is big enough to hold any key. */ > > > > Geneve

Re: [ovs-dev] [PATCH v2] odp-util: Use flexible sized buffer to hold Geneve options.

2017-12-21 Thread Justin Pettit
> On Dec 4, 2017, at 11:51 AM, Ben Pfaff wrote: > > The 'mask' buffer in parse_odp_action() is supposed to always be big > enough: >/* 'mask' is big enough to hold any key. */ > > Geneve options can be really big and the comment was wrong. In addition, > the user might

[ovs-dev] [PATCH v2] odp-util: Use flexible sized buffer to hold Geneve options.

2017-12-04 Thread Ben Pfaff
The 'mask' buffer in parse_odp_action() is supposed to always be big enough: /* 'mask' is big enough to hold any key. */ Geneve options can be really big and the comment was wrong. In addition, the user might supply more options than can really fit in any case, so we might as well just