Re: [ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

On Tue, Dec 26, 2017 at 11:12:02AM -0800, Gregory Rose wrote: > On 12/26/2017 9:33 AM, Gregory Rose wrote: > >On 12/22/2017 2:09 PM, Ben Pfaff wrote: > >>On Tue, Nov 07, 2017 at 07:04:02PM -0800, Ben Pfaff wrote: > >>>Open vSwitch has always deleted all flows from the flow table whenever > >>>a >

Re: [ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

Thanks for the review. I agree with your comments. I fixed them and applied this to master. On Fri, Jan 05, 2018 at 11:21:55AM +, Jan Scheurich wrote: > Just one small observation below. Otherwise LGTM. > > I have tested the patch and it worked for all cases. I couldn't test the case >

Re: [ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

Just one small observation below. Otherwise LGTM. I have tested the patch and it worked for all cases. I couldn't test the case that the switch loses connection to a controller in stand-alone fail mode. Acked-by: Jan Scheurich Tested-by: Jan Scheurich

Re: [ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

On 12/26/2017 9:33 AM, Gregory Rose wrote: On 12/22/2017 2:09 PM, Ben Pfaff wrote: On Tue, Nov 07, 2017 at 07:04:02PM -0800, Ben Pfaff wrote: Open vSwitch has always deleted all flows from the flow table whenever a controller is configured or whenever all the controllers are unconfigured.

Re: [ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

On 12/22/2017 2:09 PM, Ben Pfaff wrote: On Tue, Nov 07, 2017 at 07:04:02PM -0800, Ben Pfaff wrote: Open vSwitch has always deleted all flows from the flow table whenever a controller is configured or whenever all the controllers are unconfigured. After this commit, OVS additionally deletes all

Re: [ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

On Tue, Nov 07, 2017 at 07:04:02PM -0800, Ben Pfaff wrote: > Open vSwitch has always deleted all flows from the flow table whenever a > controller is configured or whenever all the controllers are unconfigured. > After this commit, OVS additionally deletes all OpenFlow groups and meters. > >

[ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

Open vSwitch has always deleted all flows from the flow table whenever a controller is configured or whenever all the controllers are unconfigured. After this commit, OVS additionally deletes all OpenFlow groups and meters. Suggested-by: Periyasamy Palanisamy