Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-01-28 Thread Han Ding
>On Tue, Jan 24, 2023 at 12:22:43PM +0100, Ilya Maximets wrote: > >... > >> I did some research that might answer or maybe clarify the questions above. >> Namely reading ARP-related RFCs - 826 and 5227.  From these I carried >> following: >> >>  - Gratuitous ARP / ARP Announcement messages are

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-01-25 Thread Simon Horman
On Tue, Jan 24, 2023 at 12:22:43PM +0100, Ilya Maximets wrote: ... > I did some research that might answer or maybe clarify the questions above. > Namely reading ARP-related RFCs - 826 and 5227. From these I carried > following: > > - Gratuitous ARP / ARP Announcement messages are generally

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-01-24 Thread Ilya Maximets
On 1/20/23 10:49, Simon Horman wrote: > Hi Han Ding, > > On Thu, Jan 05, 2023 at 02:15:03PM +0800, Han Ding wrote: >> Function is_gratuitous_arp() and function is_garp() are all used to judge >> whether the flow is gratuitous arp. It is not necessary to use two functions >> to do the same thing

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-01-20 Thread Simon Horman
Hi Han Ding, On Thu, Jan 05, 2023 at 02:15:03PM +0800, Han Ding wrote: > Function is_gratuitous_arp() and function is_garp() are all used to judge > whether the flow is gratuitous arp. It is not necessary to use two functions > to do the same thing and just keep one. I agree it is nice to

[ovs-dev] [PATCH v2] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-01-04 Thread Han Ding
Function is_gratuitous_arp() and function is_garp() are all used to judge whether the flow is gratuitous arp. It is not necessary to use two functions to do the same thing and just keep one. Acked-by: Ilya Maximets Signed-off-by: Han Ding --- lib/flow.h | 3 ++-