Re: [ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-25 Thread Roi Dayan via dev
On 2022-02-25 1:46 PM, Eelco Chaudron wrote: On 20 Feb 2022, at 14:07, Roi Dayan wrote: On 2022-02-20 1:47 PM, Roi Dayan wrote: This is leaving the revalidators in some kind of a loop. Without the patch, I do not see the problem. This is a log snippet: 2022-02-17T15:38:52.990Z|00050|

Re: [ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-25 Thread Eelco Chaudron
On 20 Feb 2022, at 14:07, Roi Dayan wrote: > On 2022-02-20 1:47 PM, Roi Dayan wrote: >>> This is leaving the revalidators in some kind of a loop. Without the patch, >>> I do not see the problem. This is a log snippet: >>> >>> 2022-02-17T15:38:52.990Z|00050|tc|WARN|expected act csum with flag

Re: [ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-20 Thread Roi Dayan via dev
On 2022-02-20 1:47 PM, Roi Dayan wrote: On 2022-02-17 5:40 PM, Eelco Chaudron wrote: On 17 Feb 2022, at 8:41, Roi Dayan wrote: On 2022-02-16 12:15 PM, Eelco Chaudron wrote: On 16 Feb 2022, at 10:48, Roi Dayan wrote: On 2022-02-16 10:37 AM, Eelco Chaudron wrote: On 15 Feb 2022, at

Re: [ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-20 Thread Roi Dayan via dev
On 2022-02-17 5:40 PM, Eelco Chaudron wrote: On 17 Feb 2022, at 8:41, Roi Dayan wrote: On 2022-02-16 12:15 PM, Eelco Chaudron wrote: On 16 Feb 2022, at 10:48, Roi Dayan wrote: On 2022-02-16 10:37 AM, Eelco Chaudron wrote: On 15 Feb 2022, at 10:52, Roi Dayan wrote: From: Chris Mi

Re: [ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-17 Thread Eelco Chaudron
On 17 Feb 2022, at 8:41, Roi Dayan wrote: > On 2022-02-16 12:15 PM, Eelco Chaudron wrote: >> >> >> On 16 Feb 2022, at 10:48, Roi Dayan wrote: >> >>> On 2022-02-16 10:37 AM, Eelco Chaudron wrote: On 15 Feb 2022, at 10:52, Roi Dayan wrote: > From: Chris Mi > > Curr

Re: [ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-16 Thread Roi Dayan via dev
On 2022-02-16 12:15 PM, Eelco Chaudron wrote: On 16 Feb 2022, at 10:48, Roi Dayan wrote: On 2022-02-16 10:37 AM, Eelco Chaudron wrote: On 15 Feb 2022, at 10:52, Roi Dayan wrote: From: Chris Mi Currently, tc merges all header rewrite actions into one tc pedit action. So the header rew

Re: [ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-16 Thread Eelco Chaudron
On 16 Feb 2022, at 10:48, Roi Dayan wrote: > On 2022-02-16 10:37 AM, Eelco Chaudron wrote: >> >> >> On 15 Feb 2022, at 10:52, Roi Dayan wrote: >> >>> From: Chris Mi >>> >>> Currently, tc merges all header rewrite actions into one tc pedit >>> action. So the header rewrite actions order is lost.

Re: [ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-16 Thread Roi Dayan via dev
On 2022-02-16 10:37 AM, Eelco Chaudron wrote: On 15 Feb 2022, at 10:52, Roi Dayan wrote: From: Chris Mi Currently, tc merges all header rewrite actions into one tc pedit action. So the header rewrite actions order is lost. Save each header rewrite action into one tc pedit action to keep t

Re: [ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-16 Thread Eelco Chaudron
On 15 Feb 2022, at 10:52, Roi Dayan wrote: > From: Chris Mi > > Currently, tc merges all header rewrite actions into one tc pedit > action. So the header rewrite actions order is lost. Save each header > rewrite action into one tc pedit action to keep the order. And only > append one tc csum ac

[ovs-dev] [PATCH v2] tc: Keep header rewrite actions order

2022-02-15 Thread Roi Dayan via dev
From: Chris Mi Currently, tc merges all header rewrite actions into one tc pedit action. So the header rewrite actions order is lost. Save each header rewrite action into one tc pedit action to keep the order. And only append one tc csum action to the last pedit action of a series. Signed-off-by