Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-15 Thread Stokes, Ian
> On 14/01/2019 13:33, Ilya Maximets wrote: > > On 14.01.2019 15:51, Ian Stokes wrote: > >> On 1/11/2019 7:37 PM, Ian Stokes wrote: > >>> On 1/11/2019 4:14 PM, Ilya Maximets wrote: > Nothing significantly changed since the previous versions. > This patch set effectively breaks following

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-14 Thread Lam, Tiago
On 14/01/2019 13:33, Ilya Maximets wrote: > On 14.01.2019 15:51, Ian Stokes wrote: >> On 1/11/2019 7:37 PM, Ian Stokes wrote: >>> On 1/11/2019 4:14 PM, Ilya Maximets wrote: Nothing significantly changed since the previous versions. This patch set effectively breaks following cases if

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-14 Thread Ilya Maximets
On 14.01.2019 18:03, Stokes, Ian wrote: >> On 14.01.2019 15:51, Ian Stokes wrote: >>> On 1/11/2019 7:37 PM, Ian Stokes wrote: On 1/11/2019 4:14 PM, Ilya Maximets wrote: > Nothing significantly changed since the previous versions. > This patch set effectively breaks following cases if

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-14 Thread Stokes, Ian
> On 14.01.2019 15:51, Ian Stokes wrote: > > On 1/11/2019 7:37 PM, Ian Stokes wrote: > >> On 1/11/2019 4:14 PM, Ilya Maximets wrote: > >>> Nothing significantly changed since the previous versions. > >>> This patch set effectively breaks following cases if multi-segment > >>> mbufs enabled: > >>>

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-14 Thread Ilya Maximets
On 14.01.2019 15:51, Ian Stokes wrote: > On 1/11/2019 7:37 PM, Ian Stokes wrote: >> On 1/11/2019 4:14 PM, Ilya Maximets wrote: >>> Nothing significantly changed since the previous versions. >>> This patch set effectively breaks following cases if multi-segment >>> mbufs enabled: >>> >> >> Hi Ilya,

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-14 Thread Ian Stokes
On 1/11/2019 7:37 PM, Ian Stokes wrote: On 1/11/2019 4:14 PM, Ilya Maximets wrote: Nothing significantly changed since the previous versions. This patch set effectively breaks following cases if multi-segment mbufs enabled: Hi Ilya, thanks for your feedback. A few queries and clarifications

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-13 Thread Lam, Tiago
On 11/01/2019 16:14, Ilya Maximets wrote: [snip] > > > > One more thing I wanted to mention is that I was surprised to not see > the performance comparison of TSO with usual Jumbo frames in your slides > on a recent OVS Conference [1]. You had a comparison slide with 1500 MTU, > TSO and

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-11 Thread Darrell Ball
On Fri, Jan 11, 2019 at 8:22 AM Ilya Maximets wrote: > Nothing significantly changed since the previous versions. > This patch set effectively breaks following cases if multi-segment > mbufs enabled: > > 1. Host <-> VM communication broken. > > With this patch applied VMs has offloading

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-11 Thread Lam, Tiago
On 11/01/2019 19:37, Ian Stokes wrote: > On 1/11/2019 4:14 PM, Ilya Maximets wrote: >> Nothing significantly changed since the previous versions. >> This patch set effectively breaks following cases if multi-segment >> mbufs enabled: >> > > Hi Ilya, thanks for your feedback. A few queries and

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-11 Thread Lam, Tiago
On 11/01/2019 16:14, Ilya Maximets wrote: [snip] > One more thing I wanted to mention is that I was surprised to not see > the performance comparison of TSO with usual Jumbo frames in your slides > on a recent OVS Conference [1]. You had a comparison slide with 1500 MTU, > TSO and the kernel

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-11 Thread Ian Stokes
On 1/11/2019 4:14 PM, Ilya Maximets wrote: Nothing significantly changed since the previous versions. This patch set effectively breaks following cases if multi-segment mbufs enabled: Hi Ilya, thanks for your feedback. A few queries and clarifications for discussion below. From reading the

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-11 Thread Ilya Maximets
Nothing significantly changed since the previous versions. This patch set effectively breaks following cases if multi-segment mbufs enabled: 1. Host <-> VM communication broken. With this patch applied VMs has offloading enabled by default. This makes all the packets that goes out

[ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-10 Thread Tiago Lam
Enabling TSO offload allows a host stack to delegate the segmentation of oversized TCP packets to the underlying physical NIC, if supported. In the case of a VM this means that the segmentation of the packets is not performed by the guest kernel, but by the host NIC itself. In turn, since the TSO