Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Use intermediate queue during packet transmission.

2017-01-18 Thread Fischetti, Antonio
Thanks Ilya for your review, please see my comments inline. Regards, Antonio > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Wednesday, January 18, 2017 7:37 AM > To: Fischetti, Antonio ; d...@openvswitch.org > Cc: acon...@redhat.com; diproiet...@vmware.

Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Use intermediate queue during packet transmission.

2017-01-17 Thread Ilya Maximets
Not a complete review. This code is full of races. See details inline. Best regards, Ilya Maximets. On 17.01.2017 18:37, antonio.fische...@intel.com wrote: > This patch implements the intermediate Tx queues on 'dpdk' type ports. > > Test results: > * In worst case scenario with fewer packets pe

[ovs-dev] [PATCH v2 1/2] netdev-dpdk: Use intermediate queue during packet transmission.

2017-01-17 Thread antonio . fischetti
This patch implements the intermediate Tx queues on 'dpdk' type ports. Test results: * In worst case scenario with fewer packets per batch, a significant bottleneck is observed for netdev_dpdk_eth_send() function due to expensive MMIO writes. * Also its observed that CPI(cycles per instru