[ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-11 Thread Mike Pattrick
Currently dp_netdev_upcall() resolves checksums on all packets, but this isn't strictly needed. The checksums will be resolved before transmission. However, we do have to resolve the checksums before sending a packet to the controller as offload flags aren't retained. Signed-off-by: Mike Pattrick

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-15 Thread Eelco Chaudron
On 11 Dec 2023, at 16:39, Mike Pattrick wrote: > Currently dp_netdev_upcall() resolves checksums on all packets, but this > isn't strictly needed. The checksums will be resolved before > transmission. However, we do have to resolve the checksums before > sending a packet to the controller as of

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-15 Thread Mike Pattrick
On Fri, Dec 15, 2023 at 8:01 AM Eelco Chaudron wrote: > > > > On 11 Dec 2023, at 16:39, Mike Pattrick wrote: > > > Currently dp_netdev_upcall() resolves checksums on all packets, but this > > isn't strictly needed. The checksums will be resolved before > > transmission. However, we do have to reso

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-15 Thread Ilya Maximets
On 12/11/23 16:39, Mike Pattrick wrote: > Currently dp_netdev_upcall() resolves checksums on all packets, but this > isn't strictly needed. The checksums will be resolved before > transmission. However, we do have to resolve the checksums before > sending a packet to the controller as offload flags

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-18 Thread Eelco Chaudron
On 15 Dec 2023, at 19:22, Mike Pattrick wrote: > On Fri, Dec 15, 2023 at 8:01 AM Eelco Chaudron wrote: >> >> >> >> On 11 Dec 2023, at 16:39, Mike Pattrick wrote: >> >>> Currently dp_netdev_upcall() resolves checksums on all packets, but this >>> isn't strictly needed. The checksums will be reso

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-18 Thread Mike Pattrick
On Mon, Dec 18, 2023 at 5:04 AM Eelco Chaudron wrote: > > > > On 15 Dec 2023, at 19:22, Mike Pattrick wrote: > > > On Fri, Dec 15, 2023 at 8:01 AM Eelco Chaudron wrote: > >> > >> > >> > >> On 11 Dec 2023, at 16:39, Mike Pattrick wrote: > >> > >>> Currently dp_netdev_upcall() resolves checksums on