Re: [ovs-dev] [PATCH v2 1/3] unixctl: Make path to unixctl_server socket available to the client.

2018-08-08 Thread Ben Pfaff
On Wed, Aug 08, 2018 at 04:13:39PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > @@ -429,10 +426,17 @@ unixctl_server_destroy(struct unixctl_server *server) > > kill_connection(conn); > > } > > > > +free (server->path); > > Just a small nit, this looks like

Re: [ovs-dev] [PATCH v2 1/3] unixctl: Make path to unixctl_server socket available to the client.

2018-08-08 Thread Aaron Conole
Ben Pfaff writes: > Acked-by: Alin Gabriel Serdean > Signed-off-by: Ben Pfaff > --- > lib/unixctl.c | 52 > lib/unixctl.h | 2 ++ > tests/daemon.at | 4 ++-- > 3 files changed, 32 insertions(+), 26 deletions(-) > > diff --git

Re: [ovs-dev] [PATCH v2 1/3] unixctl: Make path to unixctl_server socket available to the client.

2018-08-06 Thread Mark Michelson
Acked-by: Mark Michelson On 08/03/2018 01:54 PM, Ben Pfaff wrote: Acked-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff --- lib/unixctl.c | 52 lib/unixctl.h | 2 ++ tests/daemon.at | 4 ++-- 3 files changed, 32 insertions(+),

[ovs-dev] [PATCH v2 1/3] unixctl: Make path to unixctl_server socket available to the client.

2018-08-03 Thread Ben Pfaff
Acked-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff --- lib/unixctl.c | 52 lib/unixctl.h | 2 ++ tests/daemon.at | 4 ++-- 3 files changed, 32 insertions(+), 26 deletions(-) diff --git a/lib/unixctl.c b/lib/unixctl.c index