Re: [ovs-dev] [PATCH v2 1/3] windows: add definition of getpid and getcwd

2017-06-08 Thread Alin Serdean
> On Fri, May 19, 2017 at 11:16:16PM +, Alin Serdean wrote: > > > > #define WIN32_LEAN_AND_MEAN > > > > +#include > > > > #include > > > > +#include > > > > > > Thanks for the revised patch. > > > > > > Does #include make a difference? Every .c file should > > > already start out with

Re: [ovs-dev] [PATCH v2 1/3] windows: add definition of getpid and getcwd

2017-05-31 Thread Ben Pfaff
On Fri, May 19, 2017 at 11:16:16PM +, Alin Serdean wrote: > > > #define WIN32_LEAN_AND_MEAN > > > +#include > > > #include > > > +#include > > > > Thanks for the revised patch. > > > > Does #include make a difference? Every .c file should already > > start out with that #include, and

[ovs-dev] [PATCH v2 1/3] windows: add definition of getpid and getcwd

2017-05-19 Thread Alin Serdean
getcwd - is used in lib/util.c. getcwd is deprecated on Windows but has _getcwd which is defined in : https://msdn.microsoft.com/en-us/library/sf98bd4y(v=vs.120).aspx getpid - is used in several files (i.e. lib/vlog.c). getpid is also and deprecated and _getpid should be used: