Re: [ovs-dev] [PATCH v2 1/5] ovsdb-idl: Redesign use of indexes.

2018-06-12 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 07:17:13PM -0700, Han Zhou wrote: > On Mon, Jun 11, 2018 at 3:14 PM, Ben Pfaff wrote: > > +2. Pass the index, an iteration variable, and the key values to the > iterator. > > s/key values/index row objects Thanks, fixed. > > +void > > +ovsdb_idl_cursor_next_eq(struct ovs

Re: [ovs-dev] [PATCH v2 1/5] ovsdb-idl: Redesign use of indexes.

2018-06-11 Thread Han Zhou
On Mon, Jun 11, 2018 at 3:14 PM, Ben Pfaff wrote: > > The design of the compound index feature in the C OVSDB IDL was unusual. > Indexes were generally referenced only by name rather than by pointer, and > could be obtained only from the top-level ovsdb_idl object. To iterate or > otherwise searc

[ovs-dev] [PATCH v2 1/5] ovsdb-idl: Redesign use of indexes.

2018-06-11 Thread Ben Pfaff
The design of the compound index feature in the C OVSDB IDL was unusual. Indexes were generally referenced only by name rather than by pointer, and could be obtained only from the top-level ovsdb_idl object. To iterate or otherwise search an index required explicitly creating a special ovsdb_idl_c