Re: [ovs-dev] [PATCH v2 2/2] ovsdb: transaction: Calculate added/removed from diff.

2024-01-10 Thread Dumitru Ceara
On 1/9/24 20:54, Ilya Maximets wrote: > void ovsdb_datum_diff(struct ovsdb_datum *diff, > diff --git a/ovsdb/transaction.c b/ovsdb/transaction.c > index b69d03b5a..e1a87bb74 100644 > --- a/ovsdb/transaction.c > +++ b/ovsdb/transaction.c > @@ -347,12 +347,13 @@ update_row_ref_count(struct

Re: [ovs-dev] [PATCH v2 2/2] ovsdb: transaction: Calculate added/removed from diff.

2024-01-10 Thread Dumitru Ceara
On 1/9/24 20:54, Ilya Maximets wrote: > In case the difference between 'old' and 'new' rows is readily > available, it can be used to construct added/removed datums > instead. Diffs are typically much smaller than the column > itself. This change more than doubles the performance of a >

Re: [ovs-dev] [PATCH v2 2/2] ovsdb: transaction: Calculate added/removed from diff.

2024-01-09 Thread Mike Pattrick
On Tue, Jan 9, 2024 at 2:54 PM Ilya Maximets wrote: > > In case the difference between 'old' and 'new' rows is readily > available, it can be used to construct added/removed datums > instead. Diffs are typically much smaller than the column > itself. This change more than doubles the

[ovs-dev] [PATCH v2 2/2] ovsdb: transaction: Calculate added/removed from diff.

2024-01-09 Thread Ilya Maximets
In case the difference between 'old' and 'new' rows is readily available, it can be used to construct added/removed datums instead. Diffs are typically much smaller than the column itself. This change more than doubles the performance of a transaction replay. For example, with this change