Re: [ovs-dev] [PATCH v2 5/8] sflow: Fix check for disabled receive time.

2024-05-28 Thread Ilya Maximets
On 5/28/24 13:39, Eelco Chaudron wrote: > Changed sFlowRcvrTimeout to a uint32_t to avoid time_t warnings > reported by Coverity. A uint32_t is more than large enough as > this is a (seconds) tick counter and OVS is not even using this. > > Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to

Re: [ovs-dev] [PATCH v2 5/8] sflow: Fix check for disabled receive time.

2024-05-28 Thread 0-day Robot
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 97 characters long (recommended limit is 79) #38 FILE: lib/sflow_api.h:255:

[ovs-dev] [PATCH v2 5/8] sflow: Fix check for disabled receive time.

2024-05-28 Thread Eelco Chaudron
Changed sFlowRcvrTimeout to a uint32_t to avoid time_t warnings reported by Coverity. A uint32_t is more than large enough as this is a (seconds) tick counter and OVS is not even using this. Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.") Signed-off-by: Eelco Chaudron