Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Jakub Kicinski
On Tue, 25 Jun 2024 11:17:14 -0400 Aaron Conole wrote: > > BTW I popped the v2 back into the queue, so the next run (in 20min) > > will tell us if that's the only thing we were missing 爛️ > > :) I'll wait to post the v3 then. So far, the only change I have is: > > ---

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Stefano Brivio
On Tue, 25 Jun 2024 07:06:54 -0700 Jakub Kicinski wrote: > On Tue, 25 Jun 2024 09:20:29 -0400 Aaron Conole wrote: > > > I'm still wondering if the issue is Kconfig-related (plus possibly bad > > > interaction with vng). I don't see the OVS knob enabled in the self- > > > tests config. If it's

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Aaron Conole
Jakub Kicinski writes: > On Tue, 25 Jun 2024 10:14:24 -0400 Aaron Conole wrote: >> > Sorry for not checking it earlier, looks like the runner was missing >> > pyroute: >> > >> > # python3 ./tools/testing/selftests/net/openvswitch/ovs-dpctl.py >> > Need to install the python pyroute2 package >=

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Jakub Kicinski
On Tue, 25 Jun 2024 10:14:24 -0400 Aaron Conole wrote: > > Sorry for not checking it earlier, looks like the runner was missing > > pyroute: > > > > # python3 ./tools/testing/selftests/net/openvswitch/ovs-dpctl.py > > Need to install the python pyroute2 package >= 0.6. > > > > I guess run_cmd

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Aaron Conole
Jakub Kicinski writes: > On Tue, 25 Jun 2024 09:20:29 -0400 Aaron Conole wrote: >> > I'm still wondering if the issue is Kconfig-related (plus possibly bad >> > interaction with vng). I don't see the OVS knob enabled in the self- >> > tests config. If it's implied by some other knob, and ends-up

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Jakub Kicinski
On Tue, 25 Jun 2024 09:20:29 -0400 Aaron Conole wrote: > > I'm still wondering if the issue is Kconfig-related (plus possibly bad > > interaction with vng). I don't see the OVS knob enabled in the self- > > tests config. If it's implied by some other knob, and ends-up being > > selected as a

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Aaron Conole
Paolo Abeni writes: > On Mon, 2024-06-24 at 12:53 -0400, Aaron Conole wrote: >> Aaron Conole writes: >> >> > Jakub Kicinski writes: >> > >> > > On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote: >> > > > This series enhances the ovs-dpctl utility to provide support for set() >> > > > and

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Aaron Conole
Jakub Kicinski writes: > On Mon, 24 Jun 2024 12:53:45 -0400 Aaron Conole wrote: >> Additionally, the "Cannot find device ..." text comes from an iproute2 >> utility output. The only place we actually interact with that is via >> the call at pmtu.sh:973: >> >> run_cmd ip link set ovs_br0

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Stefano Brivio
On Mon, 24 Jun 2024 15:30:23 -0700 Jakub Kicinski wrote: > On Mon, 24 Jun 2024 12:53:45 -0400 Aaron Conole wrote: > > Additionally, the "Cannot find device ..." text comes from an iproute2 > > utility output. The only place we actually interact with that is via > > the call at pmtu.sh:973: > >

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-25 Thread Paolo Abeni
On Mon, 2024-06-24 at 12:53 -0400, Aaron Conole wrote: > Aaron Conole writes: > > > Jakub Kicinski writes: > > > > > On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote: > > > > This series enhances the ovs-dpctl utility to provide support for set() > > > > and tunnel() flow specifiers,

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-24 Thread Jakub Kicinski
On Mon, 24 Jun 2024 12:53:45 -0400 Aaron Conole wrote: > Additionally, the "Cannot find device ..." text comes from an iproute2 > utility output. The only place we actually interact with that is via > the call at pmtu.sh:973: > > run_cmd ip link set ovs_br0 up > > Maybe it is possible

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-24 Thread Aaron Conole
Aaron Conole writes: > Jakub Kicinski writes: > >> On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote: >>> This series enhances the ovs-dpctl utility to provide support for set() >>> and tunnel() flow specifiers, better ipv6 handling support, and the >>> ability to add tunnel vports, and LWT

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-23 Thread Aaron Conole
Jakub Kicinski writes: > On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote: >> This series enhances the ovs-dpctl utility to provide support for set() >> and tunnel() flow specifiers, better ipv6 handling support, and the >> ability to add tunnel vports, and LWT interfaces. Finally, it

Re: [ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-21 Thread Jakub Kicinski
On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote: > This series enhances the ovs-dpctl utility to provide support for set() > and tunnel() flow specifiers, better ipv6 handling support, and the > ability to add tunnel vports, and LWT interfaces. Finally, it modifies > the pmtu.sh script to

[ovs-dev] [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-20 Thread Aaron Conole
Currently, if a user wants to run pmtu.sh and cover all the provided test cases, they need to install the Open vSwitch userspace utilities. This dependency is difficult for users as well as CI environments, because the userspace build and setup may require lots of support and devel packages to be