[ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-18 Thread numans
From: Numan Siddique After the patch [1], which added caching of lflow expr, the lflow_resource_ref is not rebuilt properly when lflow_run() is called. If a lflow is already cached in lflow expr cache, then the lflow_resource_ref is not updated. But flow_output_run() clears the lflow_resource_ref

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-18 Thread Mark Michelson
Hi, Numan. Would it be possible to add a test case that exercises the fix? On 2/18/20 2:53 PM, num...@ovn.org wrote: From: Numan Siddique After the patch [1], which added caching of lflow expr, the lflow_resource_ref is not rebuilt properly when lflow_run() is called. If a lflow is already cac

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-18 Thread Numan Siddique
On Wed, Feb 19, 2020, 3:01 AM Mark Michelson wrote: > Hi, Numan. Would it be possible to add a test case that exercises the fix? > Hi Mark, The modified test case in this patch fails without the fix. Numan > On 2/18/20 2:53 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > After th

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-18 Thread Han Zhou
On Tue, Feb 18, 2020 at 11:54 AM wrote: > > From: Numan Siddique > > After the patch [1], which added caching of lflow expr, the lflow_resource_ref > is not rebuilt properly when lflow_run() is called. If a lflow is already cached > in lflow expr cache, then the lflow_resource_ref is not updated.

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-19 Thread Numan Siddique
On Wed, Feb 19, 2020 at 1:10 PM Han Zhou wrote: > > On Tue, Feb 18, 2020 at 11:54 AM wrote: > > > > From: Numan Siddique > > > > After the patch [1], which added caching of lflow expr, the > lflow_resource_ref > > is not rebuilt properly when lflow_run() is called. If a lflow is already > cached