On 2022-03-18 7:55 PM, Eelco Chaudron wrote:
On 17 Mar 2022, at 2:01, Chris Mi wrote:
On 2022-03-11 8:53 PM, Eelco Chaudron wrote:
@@ -449,6 +462,7 @@ dpif_close(struct dpif *dpif)
if (dpif) {
struct registered_dpif_class *rc;
+dpif_offload_close(dpif);
** Not
On 17 Mar 2022, at 2:01, Chris Mi wrote:
> On 2022-03-11 8:53 PM, Eelco Chaudron wrote:
>>
>
> @@ -449,6 +462,7 @@ dpif_close(struct dpif *dpif)
>if (dpif) {
>struct registered_dpif_class *rc;
>
> +dpif_offload_close(dpif);
** Not sure
On 2022-03-11 8:53 PM, Eelco Chaudron wrote:
On 11 Mar 2022, at 3:14, Chris Mi wrote:
On 2022-03-04 6:50 PM, Eelco Chaudron wrote:
I’m re-adding some of my v18 comments, which I know are depending on Ilya’s
feedback, although I still think we should have provider classes, i.e., not
based
On 2022-03-11 8:53 PM, Eelco Chaudron wrote:
On 11 Mar 2022, at 3:14, Chris Mi wrote:
On 2022-03-04 6:50 PM, Eelco Chaudron wrote:
I’m re-adding some of my v18 comments, which I know are depending on Ilya’s
feedback, although I still think we should have provider classes, i.e., not
based
On 11 Mar 2022, at 3:14, Chris Mi wrote:
> On 2022-03-04 6:50 PM, Eelco Chaudron wrote:
>> I’m re-adding some of my v18 comments, which I know are depending on Ilya’s
>> feedback, although I still think we should have provider classes, i.e., not
>> based on the datapath class.
>>
>> Some
On 2022-03-04 6:50 PM, Eelco Chaudron wrote:
I’m re-adding some of my v18 comments, which I know are depending on Ilya’s
feedback, although I still think we should have provider classes, i.e., not
based on the datapath class.
Some other questions could still be answered regardless of Ilya’s
I’m re-adding some of my v18 comments, which I know are depending on Ilya’s
feedback, although I still think we should have provider classes, i.e., not
based on the datapath class.
Some other questions could still be answered regardless of Ilya’s feedback
(will mark them with **). Please
Bleep bloop. Greetings Chris Mi, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Remove Gerrit Change-Id's before submitting upstream.
9: Change-Id:
Implement dpif-offload API for netlink datapath. And implement a
dummy dpif-offload API for netdev datapath to make tests pass.
Issue: 2181036
Change-Id: I950c3cc3c7092c3d87602da8928ad4aa2df4f38a
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 2 +
