Re: [ovs-dev] [PATCH v3] dpif-netlink: Fix memory leak dpif_netlink_open().

2023-04-24 Thread wangyunjian via dev
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, April 24, 2023 4:20 PM > To: wangyunjian > Cc: d...@openvswitch.org; i.maxim...@ovn.org; luyicai > ; simon.hor...@corigine.com > Subject: Re: [ovs-dev] [PATCH v3] dpif-net

Re: [ovs-dev] [PATCH v3] dpif-netlink: Fix memory leak dpif_netlink_open().

2023-04-24 Thread David Marchand
Hello, On Fri, Apr 21, 2023 at 11:48 AM Yunjian Wang wrote: > > In the specific call to dpif_netlink_dp_transact() (line 398) in > dpif_netlink_open(), the 'dp' content is not being used in the branch > when no error is returned (starting line 430). Furthermore, the 'dp' > and 'buf' variables

Re: [ovs-dev] [PATCH v3] dpif-netlink: Fix memory leak dpif_netlink_open().

2023-04-21 Thread Simon Horman
On Fri, Apr 21, 2023 at 05:47:58PM +0800, Yunjian Wang wrote: > In the specific call to dpif_netlink_dp_transact() (line 398) in > dpif_netlink_open(), the 'dp' content is not being used in the branch > when no error is returned (starting line 430). Furthermore, the 'dp' > and 'buf' variables are

[ovs-dev] [PATCH v3] dpif-netlink: Fix memory leak dpif_netlink_open().

2023-04-21 Thread Yunjian Wang via dev
In the specific call to dpif_netlink_dp_transact() (line 398) in dpif_netlink_open(), the 'dp' content is not being used in the branch when no error is returned (starting line 430). Furthermore, the 'dp' and 'buf' variables are overwritten later in this same branch when a new netlink request is