Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 10:10:17AM -0800, Ben Pfaff wrote: > On Wed, Jan 17, 2018 at 04:51:20PM +, Vishal Deep Ajmera wrote: > > > You mean add more details to NEWS file explaining that change? > > > > I am not much familiar with documentation part of ovs. It will help if > > others can commen

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Ben Pfaff
On Wed, Jan 17, 2018 at 04:51:20PM +, Vishal Deep Ajmera wrote: > > You mean add more details to NEWS file explaining that change? > > I am not much familiar with documentation part of ovs. It will help if > others can comment on where this change should be documented. vswitchd/vswitch.xml ha

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Vishal Deep Ajmera
> You mean add more details to NEWS file explaining that change? I am not much familiar with documentation part of ovs. It will help if others can comment on where this change should be documented. ___ dev mailing list d...@openvswitch.org https://mail.o

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 12:43:08PM +, Vishal Deep Ajmera wrote: > Hi Flavio, Hi Vishal, > I was testing your patch and comparing the stats of tap port for both > ovs-master > and your patch. The drop stats are now matching with master. Thanks for doing that work, I appreciate it! > Ho

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Vishal Deep Ajmera
Hi Flavio, I was testing your patch and comparing the stats of tap port for both ovs-master and your patch. The drop stats are now matching with master. However I still see one more difference, in earlier case the "tx_packets" were also incremented along with "tx_dropped" when the tap port is

[ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-15 Thread Flavio Leitner
Today OVS pushes packets to the TAP interface ignoring its current state. That works because the kernel will return -EIO when it's not UP and OVS will just ignore that as it is not an OVS issue. However, it causes a huge impact when broadcasts happen when using userspace datapath accelerated with