[ovs-dev] [PATCH v3] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-02-06 Thread Han Ding
Function is_gratuitous_arp() and function is_garp() are all used to judge whether the flow is gratuitous arp. It is not necessary to use two functions to do the same thing and just keep one. Signed-off-by: Han Ding --- lib/flow.h | 15 +-- ofproto/ofproto-dpif-xla

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-02-06 Thread 0-day Robot
Bleep bloop. Greetings Han Ding, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #26 FILE: lib/flow.h:1136: if

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-02-07 Thread Simon Horman
On Tue, Feb 07, 2023 at 01:04:41PM +0800, Han Ding wrote: > > Function is_gratuitous_arp() and function is_garp() are all used to judge > whether the flow is gratuitous arp. It is not necessary to use two functions > to do the same thing and just keep one. > > Signed-off-by: Han Ding > --- > li

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-02-07 Thread Ilya Maximets
On 2/7/23 06:04, Han Ding wrote: > > Function is_gratuitous_arp() and function is_garp() are all used to judge > whether the flow is gratuitous arp. It is not necessary to use two functions > to do the same thing and just keep one. > > Signed-off-by: Han Ding > --- > lib/flow.h

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-02-07 Thread Han Ding
>On Tue, Feb 07, 2023 at 01:04:41PM +0800, Han Ding wrote: >> >> Function is_gratuitous_arp() and function is_garp() are all used to judge >> whether the flow is gratuitous arp. It is not necessary to use two functions >> to do the same thing and just keep one. >> >> Signed-off-by: Han Ding >>

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-02-07 Thread Han Ding
>On 2/7/23 06:04, Han Ding wrote: >> >> Function is_gratuitous_arp() and function is_garp() are all used to judge >> whether the flow is gratuitous arp. It is not necessary to use two functions >> to do the same thing and just keep one. >> >> Signed-off-by: Han Ding >> --- >>  lib/flow.h