>On 2/7/23 06:04, Han Ding wrote:
>>
>> Function is_gratuitous_arp() and function is_garp() are all used to judge
>> whether the flow is gratuitous arp. It is not necessary to use two functions
>> to do the same thing and just keep one.
>>
>> Signed-off-by: Han Ding
>> ---
>> lib/flow.h
>On Tue, Feb 07, 2023 at 01:04:41PM +0800, Han Ding wrote:
>>
>> Function is_gratuitous_arp() and function is_garp() are all used to judge
>> whether the flow is gratuitous arp. It is not necessary to use two functions
>> to do the same thing and just keep one.
>>
>> Signed-off-by: Han Ding
>>
On 2/7/23 06:04, Han Ding wrote:
>
> Function is_gratuitous_arp() and function is_garp() are all used to judge
> whether the flow is gratuitous arp. It is not necessary to use two functions
> to do the same thing and just keep one.
>
> Signed-off-by: Han Ding
> ---
> lib/flow.h
On Tue, Feb 07, 2023 at 01:04:41PM +0800, Han Ding wrote:
>
> Function is_gratuitous_arp() and function is_garp() are all used to judge
> whether the flow is gratuitous arp. It is not necessary to use two functions
> to do the same thing and just keep one.
>
> Signed-off-by: Han Ding
> ---
> li
Bleep bloop. Greetings Han Ding, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#26 FILE: lib/flow.h:1136:
if
Function is_gratuitous_arp() and function is_garp() are all used to judge
whether the flow is gratuitous arp. It is not necessary to use two functions
to do the same thing and just keep one.
Signed-off-by: Han Ding
---
lib/flow.h | 15 +--
ofproto/ofproto-dpif-xla