Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-11-02 Thread Ben Pfaff
I guess I had in mind that OVS_RESOLV_CONF would point to an alternate file to be used instead of /etc/resolve.conf. On Fri, Nov 02, 2018 at 02:51:19PM -0700, Yifeng Sun wrote: > Hi Ben, > > Based on the discussion, I am going to create a dns_resolve_timeout__ > specifically for > sandboxing and

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-11-02 Thread Yifeng Sun
Hi Ben, Based on the discussion, I am going to create a dns_resolve_timeout__ specifically for sandboxing and testing. In runtime, dns resolving will check the environment variable, say OVS_RESOLV_CONF, to decide whether or not to use the timeout version of actual dns resolution. Does this sound

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-11-02 Thread Ben Pfaff
On Fri, Nov 02, 2018 at 04:05:13PM -0400, Mark Michelson wrote: > On 11/01/2018 02:15 PM, Yifeng Sun wrote: > >Hi Mark, > > > >Thanks a lot for the information, that is very helpful. > > > > From your comments, I understand that we should keep the current > >DNS resolving behavior as is. The thing

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-11-02 Thread Mark Michelson
On 11/01/2018 02:15 PM, Yifeng Sun wrote: Hi Mark, Thanks a lot for the information, that is very helpful. From your comments, I understand that we should keep the current DNS resolving behavior as is. The thing we need to improve is to stop resolving if there is no /etc/resolv.conf

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-11-01 Thread Yifeng Sun
Hi Mark, Thanks a lot for the information, that is very helpful. >From your comments, I understand that we should keep the current DNS resolving behavior as is. The thing we need to improve is to stop resolving if there is no /etc/resolv.conf configured. And if /etc/resolv.conf exists and has

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-11-01 Thread Mark Michelson
On 10/31/2018 06:24 PM, Yifeng Sun wrote: Hi Ben, The dns resolving depends on libunbound's ub_resolve, which, from Numan's experience as well as my reading on its documentation, doesn't support timeout. I agree there is a bug and we should fix it. Thanks, Yifeng I don't think you're going

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-31 Thread Numan Siddique
On Thu, Nov 1, 2018, 5:18 AM Ben Pfaff Thanks! > > On Wed, Oct 31, 2018 at 04:28:00PM -0700, Yifeng Sun wrote: > > For the second question, if there is error reading /etc/resolv.conf, > > currently we print a warning and continue trying to resolve names. > > As you said, I will create a patch to

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-31 Thread Ben Pfaff
Thanks! On Wed, Oct 31, 2018 at 04:28:00PM -0700, Yifeng Sun wrote: > For the second question, if there is error reading /etc/resolv.conf, > currently we print a warning and continue trying to resolve names. > As you said, I will create a patch to let dns resolving fail for this case. > >

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-31 Thread Yifeng Sun
For the second question, if there is error reading /etc/resolv.conf, currently we print a warning and continue trying to resolve names. As you said, I will create a patch to let dns resolving fail for this case. Thanks, Yifeng On Wed, Oct 31, 2018 at 3:59 PM Ben Pfaff wrote: > OK, that answers

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-31 Thread Ben Pfaff
OK, that answers the first question. What about if no DNS servers are available; what does the resolver do in that case? On Wed, Oct 31, 2018 at 03:24:13PM -0700, Yifeng Sun wrote: > Hi Ben, > > The dns resolving depends on libunbound's ub_resolve, which, from > Numan's experience as well as my

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-31 Thread Yifeng Sun
Hi Ben, The dns resolving depends on libunbound's ub_resolve, which, from Numan's experience as well as my reading on its documentation, doesn't support timeout. I agree there is a bug and we should fix it. Thanks, Yifeng On Wed, Oct 31, 2018 at 1:59 PM Ben Pfaff wrote: > On Thu, Oct 25, 2018

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-31 Thread Ben Pfaff
On Thu, Oct 25, 2018 at 03:27:41PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > When 'make check' is called by the mock rpm build (which disables networking), > the test "ovn-nbctl: LBs - daemon" fails when it runs the command > "ovn-nbctl lb-add lb0 30.0.0.1a

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-31 Thread Numan Siddique
On Wed, Oct 31, 2018 at 11:18 PM Yifeng Sun wrote: > What I actually meant to say is to add a default timeout to present > dns_resolve__, say 15 seconds. > Then other parts of code won't need be changed. If you think this is good, > I will create a patch. > Sounds good to me. Please note that

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-31 Thread Yifeng Sun
What I actually meant to say is to add a default timeout to present dns_resolve__, say 15 seconds. Then other parts of code won't need be changed. If you think this is good, I will create a patch. Thanks, Yifeng On Tue, Oct 30, 2018 at 9:34 PM Numan Siddique wrote: > > > On Tue, Oct 30, 2018

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-30 Thread Numan Siddique
On Tue, Oct 30, 2018 at 11:50 PM Yifeng Sun wrote: > I feel another option to fix this issue is to add a new function like > dns_resolve_timeout__, what do you think? > I think that can fix the problem. I am not too familiar with libunbound. Does it support specifying a timeout or aync approch

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-30 Thread Yifeng Sun
I feel another option to fix this issue is to add a new function like dns_resolve_timeout__, what do you think? Thanks, Yifeng On Thu, Oct 25, 2018 at 2:58 AM wrote: > From: Numan Siddique > > When 'make check' is called by the mock rpm build (which disables > networking), > the test

[ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-10-25 Thread nusiddiq
From: Numan Siddique When 'make check' is called by the mock rpm build (which disables networking), the test "ovn-nbctl: LBs - daemon" fails when it runs the command "ovn-nbctl lb-add lb0 30.0.0.1a 192.168.10.10:80,192.168.10.20:80". ovn-nbctl extracts the vip by calling the socket util function