Re: [ovs-dev] [PATCH v3 08/17] hmap: implement UB-safe hmap pop iterator

2022-02-25 Thread Dumitru Ceara
On 2/16/22 15:27, Adrian Moreno wrote: > HMAP_FOR_EACH_POP iterator has an additional difficulty, which is the > use of two iterator variables of different types. > > In order to re-write this loop in a UB-safe manner, create a iterator > struct to be used as loop variable. > > Signed-off-by:

Re: [ovs-dev] [PATCH v3 08/17] hmap: implement UB-safe hmap pop iterator

2022-02-16 Thread 0-day Robot
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Use ovs_assert() in place of assert() #76 FILE: tests/test-hmap.c:320:

[ovs-dev] [PATCH v3 08/17] hmap: implement UB-safe hmap pop iterator

2022-02-16 Thread Adrian Moreno
HMAP_FOR_EACH_POP iterator has an additional difficulty, which is the use of two iterator variables of different types. In order to re-write this loop in a UB-safe manner, create a iterator struct to be used as loop variable. Signed-off-by: Adrian Moreno --- include/openvswitch/hmap.h | 31