[ovs-dev] [PATCH v3 1/2] conntrack: fix tcp seq adjustments when mangling commands

2019-01-09 Thread David Marchand
The ftp alg deals with packets in two ways for the command connection: either they are inspected and can be mangled when nat is enabled (CT_FTP_CTL_INTEREST) or they just go through without being modified (CT_FTP_CTL_OTHER). For CT_FTP_CTL_INTEREST packets, we must both adjust the packet tcp seq n

Re: [ovs-dev] [PATCH v3 1/2] conntrack: fix tcp seq adjustments when mangling commands

2019-01-13 Thread Darrell Ball
Thanks for the patch On Wed, Jan 9, 2019 at 7:33 AM David Marchand wrote: The ftp alg deals with packets in two ways for the command connection: > either they are inspected and can be mangled when nat is enabled > (CT_FTP_CTL_INTEREST) or they just go through without being modified > (CT_FTP_CTL

Re: [ovs-dev] [PATCH v3 1/2] conntrack: fix tcp seq adjustments when mangling commands

2019-01-14 Thread David Marchand
On Mon, Jan 14, 2019 at 7:32 AM Darrell Ball wrote: > Thanks for the patch > > On Wed, Jan 9, 2019 at 7:33 AM David Marchand > wrote: > > The ftp alg deals with packets in two ways for the command connection: >> either they are inspected and can be mangled when nat is enabled >> (CT_FTP_CTL_INTE

Re: [ovs-dev] [PATCH v3 1/2] conntrack: fix tcp seq adjustments when mangling commands

2019-01-14 Thread Darrell Ball via dev
On 1/14/19, 4:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of David Marchand" wrote: On Mon, Jan 14, 2019 at 7:32 AM Darrell Ball wrote: > Thanks for the patch > > On Wed, Jan 9, 2019 at 7:33 AM David Marchand > wrote: > > The ftp alg deals with packets

Re: [ovs-dev] [PATCH v3 1/2] conntrack: fix tcp seq adjustments when mangling commands

2019-01-15 Thread David Marchand
On Tue, Jan 15, 2019 at 8:20 AM Darrell Ball wrote: > > On 1/14/19, 4:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of David > Marchand" david.march...@redhat.com> wrote: > > On Mon, Jan 14, 2019 at 7:32 AM Darrell Ball wrote: > > > 4/ I added another test below for reverse skew. >