Re: [ovs-dev] [PATCH v3 3/3] datapath-windows: Optimize conntrack lock implementation.

2018-01-29 Thread Anand Kumar
Hi Alin, Thanks for the review. I’ll address the warning and send out the patch. Thanks, Anand Kumar On 1/29/18, 5:20 AM, "Alin Serdean" wrote: Trimming the patch a bit. Just one small nit from the static analyzer inlined. Rest looks good. Acked-by: Alin Gabriel

Re: [ovs-dev] [PATCH v3 3/3] datapath-windows: Optimize conntrack lock implementation.

2018-01-29 Thread Alin Serdean
Trimming the patch a bit. Just one small nit from the static analyzer inlined. Rest looks good. Acked-by: Alin Gabriel Serdean <--8<--> /* @@ -124,12 +135,9 @@ OvsInitConntrack(POVS_SWITCH_CONTEXT context) VOI

[ovs-dev] [PATCH v3 3/3] datapath-windows: Optimize conntrack lock implementation.

2018-01-23 Thread Anand Kumar
Currently, there is one global lock for conntrack module, which protects conntrack entries and conntrack table. All the NAT operations are performed holding this lock. This becomes inefficient, as the number of conntrack entries grow. With new implementation, we will have two PNDIS_RW_LOCK_EX lock