Re: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Refactor TSO request code.

2024-05-15 Thread Kevin Traynor
On 13/05/2024 08:13, David Marchand wrote: > Hello Kevin, > > Thanks for reviewing. > > On Fri, May 10, 2024 at 11:50 PM Kevin Traynor wrote: >> >> On 19/04/2024 15:06, David Marchand wrote: >>> Replace check on th == NULL with an assert() because dp_packet_l4(pkt) >>> is priorly used to compute

Re: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Refactor TSO request code.

2024-05-13 Thread David Marchand
Hello Kevin, Thanks for reviewing. On Fri, May 10, 2024 at 11:50 PM Kevin Traynor wrote: > > On 19/04/2024 15:06, David Marchand wrote: > > Replace check on th == NULL with an assert() because dp_packet_l4(pkt) > > is priorly used to compute (outer) L3 length. > > > > Besides, filling l4_len and

Re: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Refactor TSO request code.

2024-05-10 Thread Kevin Traynor
On 19/04/2024 15:06, David Marchand wrote: > Replace check on th == NULL with an assert() because dp_packet_l4(pkt) > is priorly used to compute (outer) L3 length. > > Besides, filling l4_len and tso_segsz only matters to TSO, so there is > no need to check for other L4 checksum offloading request

[ovs-dev] [PATCH v3 4/6] netdev-dpdk: Refactor TSO request code.

2024-04-19 Thread David Marchand
Replace check on th == NULL with an assert() because dp_packet_l4(pkt) is priorly used to compute (outer) L3 length. Besides, filling l4_len and tso_segsz only matters to TSO, so there is no need to check for other L4 checksum offloading requests. Signed-off-by: David Marchand --- lib/netdev-dp